-
Notifications
You must be signed in to change notification settings - Fork 323
Enable instrumentationNamingCheck on CI #10282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
approved these changes
Jan 2, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084483
Total [baseline] (8.749 s) : 0, 8749159
Agent [candidate] (1.083 s) : 0, 1082521
Total [candidate] (8.719 s) : 0, 8719354
section iast
Agent [baseline] (1.228 s) : 0, 1228060
Total [baseline] (9.316 s) : 0, 9316091
Agent [candidate] (1.237 s) : 0, 1237087
Total [candidate] (9.308 s) : 0, 9307575
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (650.6 ms) : 0, 650600
BytebuddyAgent [candidate] (650.794 ms) : 0, 650794
GlobalTracer [baseline] (282.5 ms) : 0, 282500
GlobalTracer [candidate] (282.209 ms) : 0, 282209
AppSec [baseline] (32.81 ms) : 0, 32810
AppSec [candidate] (32.644 ms) : 0, 32644
Debugger [baseline] (68.34 ms) : 0, 68340
Debugger [candidate] (66.793 ms) : 0, 66793
Remote Config [baseline] (706.116 µs) : 0, 706
Remote Config [candidate] (630.984 µs) : 0, 631
Telemetry [baseline] (9.057 ms) : 0, 9057
Telemetry [candidate] (9.015 ms) : 0, 9015
Flare Poller [baseline] (3.776 ms) : 0, 3776
Flare Poller [candidate] (3.812 ms) : 0, 3812
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (795.558 ms) : 0, 795558
BytebuddyAgent [candidate] (802.682 ms) : 0, 802682
GlobalTracer [baseline] (256.057 ms) : 0, 256057
GlobalTracer [candidate] (258.344 ms) : 0, 258344
AppSec [baseline] (34.658 ms) : 0, 34658
AppSec [candidate] (34.257 ms) : 0, 34257
Debugger [baseline] (65.002 ms) : 0, 65002
Debugger [candidate] (64.945 ms) : 0, 64945
Remote Config [baseline] (596.68 µs) : 0, 597
Remote Config [candidate] (622.579 µs) : 0, 623
Telemetry [baseline] (8.544 ms) : 0, 8544
Telemetry [candidate] (8.488 ms) : 0, 8488
Flare Poller [baseline] (3.513 ms) : 0, 3513
Flare Poller [candidate] (3.498 ms) : 0, 3498
IAST [baseline] (27.285 ms) : 0, 27285
IAST [candidate] (27.374 ms) : 0, 27374
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085401
Total [baseline] (10.787 s) : 0, 10787109
Agent [candidate] (1.082 s) : 0, 1081575
Total [candidate] (10.754 s) : 0, 10753611
section appsec
Agent [baseline] (1.27 s) : 0, 1270270
Total [baseline] (11.005 s) : 0, 11004892
Agent [candidate] (1.271 s) : 0, 1271418
Total [candidate] (10.907 s) : 0, 10906919
section iast
Agent [baseline] (1.229 s) : 0, 1229369
Total [baseline] (11.153 s) : 0, 11152564
Agent [candidate] (1.223 s) : 0, 1222892
Total [candidate] (11.15 s) : 0, 11149686
section profiling
Agent [baseline] (1.207 s) : 0, 1206862
Total [baseline] (10.978 s) : 0, 10977710
Agent [candidate] (1.205 s) : 0, 1205442
Total [candidate] (10.967 s) : 0, 10966791
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (651.738 ms) : 0, 651738
BytebuddyAgent [candidate] (649.121 ms) : 0, 649121
GlobalTracer [baseline] (282.683 ms) : 0, 282683
GlobalTracer [candidate] (281.74 ms) : 0, 281740
AppSec [baseline] (32.586 ms) : 0, 32586
AppSec [candidate] (32.522 ms) : 0, 32522
Debugger [baseline] (68.319 ms) : 0, 68319
Debugger [candidate] (68.205 ms) : 0, 68205
Remote Config [baseline] (627.947 µs) : 0, 628
Remote Config [candidate] (634.37 µs) : 0, 634
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.971 ms) : 0, 8971
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.751 ms) : 0, 3751
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (695.471 ms) : 0, 695471
BytebuddyAgent [candidate] (694.077 ms) : 0, 694077
GlobalTracer [baseline] (258.809 ms) : 0, 258809
GlobalTracer [candidate] (259.876 ms) : 0, 259876
AppSec [baseline] (173.465 ms) : 0, 173465
AppSec [candidate] (174.462 ms) : 0, 174462
Debugger [baseline] (66.888 ms) : 0, 66888
Debugger [candidate] (67.244 ms) : 0, 67244
Remote Config [baseline] (933.501 µs) : 0, 934
Remote Config [candidate] (787.455 µs) : 0, 787
Telemetry [baseline] (9.265 ms) : 0, 9265
Telemetry [candidate] (9.471 ms) : 0, 9471
Flare Poller [baseline] (3.836 ms) : 0, 3836
Flare Poller [candidate] (3.83 ms) : 0, 3830
IAST [baseline] (24.922 ms) : 0, 24922
IAST [candidate] (24.963 ms) : 0, 24963
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (795.052 ms) : 0, 795052
BytebuddyAgent [candidate] (791.072 ms) : 0, 791072
GlobalTracer [baseline] (256.353 ms) : 0, 256353
GlobalTracer [candidate] (255.088 ms) : 0, 255088
AppSec [baseline] (33.73 ms) : 0, 33730
AppSec [candidate] (34.682 ms) : 0, 34682
Debugger [baseline] (67.201 ms) : 0, 67201
Debugger [candidate] (65.951 ms) : 0, 65951
Remote Config [baseline] (592.715 µs) : 0, 593
Remote Config [candidate] (573.359 µs) : 0, 573
Telemetry [baseline] (8.698 ms) : 0, 8698
Telemetry [candidate] (8.488 ms) : 0, 8488
Flare Poller [baseline] (3.64 ms) : 0, 3640
Flare Poller [candidate] (3.476 ms) : 0, 3476
IAST [baseline] (27.303 ms) : 0, 27303
IAST [candidate] (26.988 ms) : 0, 26988
section profiling
ProfilingAgent [baseline] (96.886 ms) : 0, 96886
ProfilingAgent [candidate] (96.101 ms) : 0, 96101
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (704.748 ms) : 0, 704748
BytebuddyAgent [candidate] (704.211 ms) : 0, 704211
GlobalTracer [baseline] (220.569 ms) : 0, 220569
GlobalTracer [candidate] (220.937 ms) : 0, 220937
AppSec [baseline] (32.397 ms) : 0, 32397
AppSec [candidate] (32.157 ms) : 0, 32157
Debugger [baseline] (68.045 ms) : 0, 68045
Debugger [candidate] (67.956 ms) : 0, 67956
Remote Config [baseline] (646.689 µs) : 0, 647
Remote Config [candidate] (626.059 µs) : 0, 626
Telemetry [baseline] (8.804 ms) : 0, 8804
Telemetry [candidate] (8.694 ms) : 0, 8694
Flare Poller [baseline] (3.733 ms) : 0, 3733
Flare Poller [candidate] (3.72 ms) : 0, 3720
Profiling [baseline] (97.458 ms) : 0, 97458
Profiling [candidate] (96.679 ms) : 0, 96679
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1164, 1186
. : milestone, 1175,
iast (3.236 ms) : 3188, 3284
. : milestone, 3236,
iast_FULL (5.7 ms) : 5644, 5756
. : milestone, 5700,
iast_GLOBAL (3.605 ms) : 3544, 3666
. : milestone, 3605,
profiling (1.982 ms) : 1965, 1998
. : milestone, 1982,
tracing (1.806 ms) : 1790, 1822
. : milestone, 1806,
section candidate
no_agent (1.192 ms) : 1181, 1204
. : milestone, 1192,
iast (3.103 ms) : 3062, 3144
. : milestone, 3103,
iast_FULL (5.621 ms) : 5566, 5677
. : milestone, 5621,
iast_GLOBAL (3.597 ms) : 3544, 3649
. : milestone, 3597,
profiling (2.02 ms) : 2002, 2038
. : milestone, 2020,
tracing (1.787 ms) : 1771, 1803
. : milestone, 1787,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section baseline
no_agent (19.216 ms) : 19019, 19413
. : milestone, 19216,
appsec (18.638 ms) : 18452, 18825
. : milestone, 18638,
code_origins (17.709 ms) : 17533, 17886
. : milestone, 17709,
iast (17.686 ms) : 17508, 17863
. : milestone, 17686,
profiling (18.691 ms) : 18508, 18875
. : milestone, 18691,
tracing (18.727 ms) : 18538, 18916
. : milestone, 18727,
section candidate
no_agent (18.082 ms) : 17893, 18272
. : milestone, 18082,
appsec (18.505 ms) : 18318, 18693
. : milestone, 18505,
code_origins (18.904 ms) : 18714, 19095
. : milestone, 18904,
iast (17.422 ms) : 17249, 17595
. : milestone, 17422,
profiling (18.462 ms) : 18276, 18649
. : milestone, 18462,
tracing (17.663 ms) : 17486, 17839
. : milestone, 17663,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.711 ms) : 3490, 3933
. : milestone, 3711,
iast (2.213 ms) : 2148, 2278
. : milestone, 2213,
iast_GLOBAL (2.249 ms) : 2184, 2314
. : milestone, 2249,
profiling (2.493 ms) : 2327, 2659
. : milestone, 2493,
tracing (2.045 ms) : 1994, 2096
. : milestone, 2045,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.717 ms) : 3495, 3939
. : milestone, 3717,
iast (2.205 ms) : 2141, 2270
. : milestone, 2205,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.094 ms) : 2039, 2148
. : milestone, 2094,
tracing (2.045 ms) : 1994, 2096
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~14bbf23f5f, baseline=1.58.0-SNAPSHOT~68c7c2aab22
dateFormat X
axisFormat %s
section baseline
no_agent (15.558 s) : 15558000, 15558000
. : milestone, 15558000,
appsec (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
iast (18.328 s) : 18328000, 18328000
. : milestone, 18328000,
iast_GLOBAL (17.552 s) : 17552000, 17552000
. : milestone, 17552000,
profiling (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
tracing (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
section candidate
no_agent (15.738 s) : 15738000, 15738000
. : milestone, 15738000,
appsec (14.691 s) : 14691000, 14691000
. : milestone, 14691000,
iast (18.187 s) : 18187000, 18187000
. : milestone, 18187000,
iast_GLOBAL (17.751 s) : 17751000, 17751000
. : milestone, 17751000,
profiling (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
tracing (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR enforces instrumentation gradle module naming checks on the CI and updates the documentation to explain the rules to follow
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]