-
Notifications
You must be signed in to change notification settings - Fork 322
Migrate aerospike to instrumenter module #10283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7d487a8 to
4973f17
Compare
4973f17 to
85ed373
Compare
5a7ea26 to
91e6bf3
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088011
Total [baseline] (8.804 s) : 0, 8803805
Agent [candidate] (1.09 s) : 0, 1090339
Total [candidate] (8.761 s) : 0, 8761260
section iast
Agent [baseline] (1.23 s) : 0, 1229950
Total [baseline] (9.31 s) : 0, 9310178
Agent [candidate] (1.221 s) : 0, 1221476
Total [candidate] (9.33 s) : 0, 9329817
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (653.702 ms) : 0, 653702
BytebuddyAgent [candidate] (655.621 ms) : 0, 655621
GlobalTracer [baseline] (283.659 ms) : 0, 283659
GlobalTracer [candidate] (283.649 ms) : 0, 283649
AppSec [baseline] (32.731 ms) : 0, 32731
AppSec [candidate] (32.793 ms) : 0, 32793
Debugger [baseline] (67.67 ms) : 0, 67670
Debugger [candidate] (68.027 ms) : 0, 68027
Remote Config [baseline] (628.359 µs) : 0, 628
Remote Config [candidate] (626.167 µs) : 0, 626
Telemetry [baseline] (9.154 ms) : 0, 9154
Telemetry [candidate] (8.95 ms) : 0, 8950
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.779 ms) : 0, 3779
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (796.489 ms) : 0, 796489
BytebuddyAgent [candidate] (790.063 ms) : 0, 790063
GlobalTracer [baseline] (257.352 ms) : 0, 257352
GlobalTracer [candidate] (255.885 ms) : 0, 255885
IAST [baseline] (27.257 ms) : 0, 27257
IAST [candidate] (27.009 ms) : 0, 27009
AppSec [baseline] (32.788 ms) : 0, 32788
AppSec [candidate] (35.212 ms) : 0, 35212
Debugger [baseline] (66.831 ms) : 0, 66831
Debugger [candidate] (64.062 ms) : 0, 64062
Remote Config [baseline] (591.599 µs) : 0, 592
Remote Config [candidate] (617.11 µs) : 0, 617
Telemetry [baseline] (8.49 ms) : 0, 8490
Telemetry [candidate] (8.485 ms) : 0, 8485
Flare Poller [baseline] (3.497 ms) : 0, 3497
Flare Poller [candidate] (3.586 ms) : 0, 3586
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083764
Total [baseline] (10.891 s) : 0, 10890857
Agent [candidate] (1.091 s) : 0, 1090703
Total [candidate] (10.921 s) : 0, 10920601
section appsec
Agent [baseline] (1.267 s) : 0, 1266615
Total [baseline] (10.9 s) : 0, 10899899
Agent [candidate] (1.265 s) : 0, 1264569
Total [candidate] (10.968 s) : 0, 10968491
section iast
Agent [baseline] (1.223 s) : 0, 1222628
Total [baseline] (11.132 s) : 0, 11131995
Agent [candidate] (1.224 s) : 0, 1224446
Total [candidate] (11.156 s) : 0, 11156051
section profiling
Agent [baseline] (1.205 s) : 0, 1204817
Total [baseline] (10.936 s) : 0, 10936360
Agent [candidate] (1.207 s) : 0, 1207170
Total [candidate] (10.929 s) : 0, 10928748
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (650.198 ms) : 0, 650198
BytebuddyAgent [candidate] (654.128 ms) : 0, 654128
GlobalTracer [baseline] (282.459 ms) : 0, 282459
GlobalTracer [candidate] (284.558 ms) : 0, 284558
AppSec [baseline] (32.612 ms) : 0, 32612
AppSec [candidate] (32.918 ms) : 0, 32918
Debugger [baseline] (68.462 ms) : 0, 68462
Debugger [candidate] (68.737 ms) : 0, 68737
Remote Config [baseline] (656.17 µs) : 0, 656
Remote Config [candidate] (641.97 µs) : 0, 642
Telemetry [baseline] (8.954 ms) : 0, 8954
Telemetry [candidate] (9.156 ms) : 0, 9156
Flare Poller [baseline] (3.78 ms) : 0, 3780
Flare Poller [candidate] (3.812 ms) : 0, 3812
section appsec
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (693.298 ms) : 0, 693298
BytebuddyAgent [candidate] (690.214 ms) : 0, 690214
GlobalTracer [baseline] (258.466 ms) : 0, 258466
GlobalTracer [candidate] (257.672 ms) : 0, 257672
IAST [baseline] (24.687 ms) : 0, 24687
IAST [candidate] (24.654 ms) : 0, 24654
AppSec [baseline] (173.63 ms) : 0, 173630
AppSec [candidate] (173.499 ms) : 0, 173499
Debugger [baseline] (66.175 ms) : 0, 66175
Debugger [candidate] (68.03 ms) : 0, 68030
Remote Config [baseline] (761.612 µs) : 0, 762
Remote Config [candidate] (750.385 µs) : 0, 750
Telemetry [baseline] (9.221 ms) : 0, 9221
Telemetry [candidate] (9.359 ms) : 0, 9359
Flare Poller [baseline] (3.707 ms) : 0, 3707
Flare Poller [candidate] (3.785 ms) : 0, 3785
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (790.24 ms) : 0, 790240
BytebuddyAgent [candidate] (791.628 ms) : 0, 791628
GlobalTracer [baseline] (255.531 ms) : 0, 255531
GlobalTracer [candidate] (256.595 ms) : 0, 256595
IAST [baseline] (27.158 ms) : 0, 27158
IAST [candidate] (26.984 ms) : 0, 26984
AppSec [baseline] (34.305 ms) : 0, 34305
AppSec [candidate] (31.864 ms) : 0, 31864
Debugger [baseline] (66.174 ms) : 0, 66174
Debugger [candidate] (68.166 ms) : 0, 68166
Remote Config [baseline] (592.133 µs) : 0, 592
Remote Config [candidate] (548.403 µs) : 0, 548
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.466 ms) : 0, 8466
Flare Poller [baseline] (3.501 ms) : 0, 3501
Flare Poller [candidate] (3.573 ms) : 0, 3573
section profiling
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (702.899 ms) : 0, 702899
BytebuddyAgent [candidate] (703.878 ms) : 0, 703878
GlobalTracer [baseline] (220.301 ms) : 0, 220301
GlobalTracer [candidate] (221.325 ms) : 0, 221325
AppSec [baseline] (32.145 ms) : 0, 32145
AppSec [candidate] (32.381 ms) : 0, 32381
Debugger [baseline] (68.186 ms) : 0, 68186
Debugger [candidate] (68.251 ms) : 0, 68251
Remote Config [baseline] (645.994 µs) : 0, 646
Remote Config [candidate] (625.801 µs) : 0, 626
Telemetry [baseline] (8.83 ms) : 0, 8830
Telemetry [candidate] (8.793 ms) : 0, 8793
Flare Poller [baseline] (3.7 ms) : 0, 3700
Flare Poller [candidate] (3.665 ms) : 0, 3665
ProfilingAgent [baseline] (97.235 ms) : 0, 97235
ProfilingAgent [candidate] (97.328 ms) : 0, 97328
Profiling [baseline] (97.826 ms) : 0, 97826
Profiling [candidate] (97.899 ms) : 0, 97899
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1178, 1202
. : milestone, 1190,
iast (3.18 ms) : 3145, 3215
. : milestone, 3180,
iast_FULL (5.823 ms) : 5766, 5881
. : milestone, 5823,
iast_GLOBAL (3.72 ms) : 3663, 3776
. : milestone, 3720,
profiling (1.936 ms) : 1919, 1953
. : milestone, 1936,
tracing (1.802 ms) : 1787, 1817
. : milestone, 1802,
section candidate
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.124 ms) : 3084, 3164
. : milestone, 3124,
iast_FULL (5.676 ms) : 5619, 5734
. : milestone, 5676,
iast_GLOBAL (3.559 ms) : 3502, 3615
. : milestone, 3559,
profiling (1.916 ms) : 1899, 1933
. : milestone, 1916,
tracing (1.797 ms) : 1782, 1812
. : milestone, 1797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section baseline
no_agent (19.188 ms) : 18988, 19388
. : milestone, 19188,
appsec (19.84 ms) : 19638, 20042
. : milestone, 19840,
code_origins (17.624 ms) : 17447, 17801
. : milestone, 17624,
iast (18.081 ms) : 17900, 18263
. : milestone, 18081,
profiling (18.886 ms) : 18700, 19072
. : milestone, 18886,
tracing (18.001 ms) : 17820, 18182
. : milestone, 18001,
section candidate
no_agent (19.178 ms) : 18982, 19375
. : milestone, 19178,
appsec (19.622 ms) : 19418, 19826
. : milestone, 19622,
code_origins (17.563 ms) : 17387, 17738
. : milestone, 17563,
iast (18.713 ms) : 18527, 18899
. : milestone, 18713,
profiling (18.698 ms) : 18510, 18887
. : milestone, 18698,
tracing (17.757 ms) : 17580, 17933
. : milestone, 17757,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.689 ms) : 3466, 3911
. : milestone, 3689,
iast (2.204 ms) : 2140, 2269
. : milestone, 2204,
iast_GLOBAL (2.244 ms) : 2179, 2309
. : milestone, 2244,
profiling (2.084 ms) : 2030, 2139
. : milestone, 2084,
tracing (2.037 ms) : 1986, 2088
. : milestone, 2037,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.713 ms) : 3494, 3933
. : milestone, 3713,
iast (2.204 ms) : 2139, 2269
. : milestone, 2204,
iast_GLOBAL (2.246 ms) : 2181, 2311
. : milestone, 2246,
profiling (2.064 ms) : 2011, 2117
. : milestone, 2064,
tracing (2.037 ms) : 1986, 2088
. : milestone, 2037,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~91e6bf31d9, baseline=1.58.0-SNAPSHOT~8ffeb2915d
dateFormat X
axisFormat %s
section baseline
no_agent (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
appsec (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
iast (18.023 s) : 18023000, 18023000
. : milestone, 18023000,
iast_GLOBAL (17.743 s) : 17743000, 17743000
. : milestone, 17743000,
profiling (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
tracing (14.595 s) : 14595000, 14595000
. : milestone, 14595000,
section candidate
no_agent (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
appsec (14.531 s) : 14531000, 14531000
. : milestone, 14531000,
iast (17.659 s) : 17659000, 17659000
. : milestone, 17659000,
iast_GLOBAL (17.922 s) : 17922000, 17922000
. : milestone, 17922000,
profiling (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
tracing (14.478 s) : 14478000, 14478000
. : milestone, 14478000,
|
mcculls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]