-
Notifications
You must be signed in to change notification settings - Fork 322
Port akka http instrumentation to instrumenter module api #10285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amarziali
wants to merge
5
commits into
master
Choose a base branch
from
andrea.marziali/im-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+340
−590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082792
Total [baseline] (10.818 s) : 0, 10817659
Agent [candidate] (1.09 s) : 0, 1090453
Total [candidate] (10.906 s) : 0, 10905609
section appsec
Agent [baseline] (1.265 s) : 0, 1265234
Total [baseline] (10.933 s) : 0, 10933223
Agent [candidate] (1.262 s) : 0, 1262382
Total [candidate] (10.95 s) : 0, 10950443
section iast
Agent [baseline] (1.223 s) : 0, 1222540
Total [baseline] (11.049 s) : 0, 11048781
Agent [candidate] (1.226 s) : 0, 1225876
Total [candidate] (11.214 s) : 0, 11214286
section profiling
Agent [baseline] (1.212 s) : 0, 1211654
Total [baseline] (10.925 s) : 0, 10925206
Agent [candidate] (1.202 s) : 0, 1201893
Total [candidate] (10.875 s) : 0, 10874840
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (649.838 ms) : 0, 649838
BytebuddyAgent [candidate] (652.379 ms) : 0, 652379
GlobalTracer [baseline] (282.097 ms) : 0, 282097
GlobalTracer [candidate] (285.002 ms) : 0, 285002
AppSec [baseline] (32.523 ms) : 0, 32523
AppSec [candidate] (33.013 ms) : 0, 33013
Debugger [baseline] (68.362 ms) : 0, 68362
Debugger [candidate] (69.44 ms) : 0, 69440
Remote Config [baseline] (639.0 µs) : 0, 639
Remote Config [candidate] (632.009 µs) : 0, 632
Telemetry [baseline] (9.007 ms) : 0, 9007
Telemetry [candidate] (9.343 ms) : 0, 9343
Flare Poller [baseline] (3.715 ms) : 0, 3715
Flare Poller [candidate] (3.884 ms) : 0, 3884
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (691.932 ms) : 0, 691932
BytebuddyAgent [candidate] (688.959 ms) : 0, 688959
GlobalTracer [baseline] (257.998 ms) : 0, 257998
GlobalTracer [candidate] (258.229 ms) : 0, 258229
IAST [baseline] (24.618 ms) : 0, 24618
IAST [candidate] (24.482 ms) : 0, 24482
AppSec [baseline] (174.079 ms) : 0, 174079
AppSec [candidate] (172.207 ms) : 0, 172207
Debugger [baseline] (66.049 ms) : 0, 66049
Debugger [candidate] (68.365 ms) : 0, 68365
Remote Config [baseline] (711.099 µs) : 0, 711
Remote Config [candidate] (750.329 µs) : 0, 750
Telemetry [baseline] (9.425 ms) : 0, 9425
Telemetry [candidate] (9.185 ms) : 0, 9185
Flare Poller [baseline] (3.747 ms) : 0, 3747
Flare Poller [candidate] (3.619 ms) : 0, 3619
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (790.711 ms) : 0, 790711
BytebuddyAgent [candidate] (792.576 ms) : 0, 792576
GlobalTracer [baseline] (255.12 ms) : 0, 255120
GlobalTracer [candidate] (256.533 ms) : 0, 256533
IAST [baseline] (27.139 ms) : 0, 27139
IAST [candidate] (27.076 ms) : 0, 27076
AppSec [baseline] (33.59 ms) : 0, 33590
AppSec [candidate] (33.688 ms) : 0, 33688
Debugger [baseline] (66.874 ms) : 0, 66874
Debugger [candidate] (66.623 ms) : 0, 66623
Remote Config [baseline] (566.884 µs) : 0, 567
Remote Config [candidate] (579.847 µs) : 0, 580
Telemetry [baseline] (8.473 ms) : 0, 8473
Telemetry [candidate] (8.514 ms) : 0, 8514
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.559 ms) : 0, 3559
section profiling
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (707.463 ms) : 0, 707463
BytebuddyAgent [candidate] (700.304 ms) : 0, 700304
GlobalTracer [baseline] (221.645 ms) : 0, 221645
GlobalTracer [candidate] (220.191 ms) : 0, 220191
AppSec [baseline] (32.247 ms) : 0, 32247
AppSec [candidate] (32.025 ms) : 0, 32025
Debugger [baseline] (68.567 ms) : 0, 68567
Debugger [candidate] (67.927 ms) : 0, 67927
Remote Config [baseline] (628.143 µs) : 0, 628
Remote Config [candidate] (677.524 µs) : 0, 678
Telemetry [baseline] (8.876 ms) : 0, 8876
Telemetry [candidate] (8.978 ms) : 0, 8978
Flare Poller [baseline] (3.705 ms) : 0, 3705
Flare Poller [candidate] (3.764 ms) : 0, 3764
ProfilingAgent [baseline] (97.251 ms) : 0, 97251
ProfilingAgent [candidate] (96.979 ms) : 0, 96979
Profiling [baseline] (97.824 ms) : 0, 97824
Profiling [candidate] (97.587 ms) : 0, 97587
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091556
Total [baseline] (8.736 s) : 0, 8735964
Agent [candidate] (1.086 s) : 0, 1085526
Total [candidate] (8.749 s) : 0, 8748735
section iast
Agent [baseline] (1.22 s) : 0, 1219903
Total [baseline] (9.297 s) : 0, 9297301
Agent [candidate] (1.236 s) : 0, 1235873
Total [candidate] (9.355 s) : 0, 9355239
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (656.014 ms) : 0, 656014
BytebuddyAgent [candidate] (652.0 ms) : 0, 652000
GlobalTracer [baseline] (284.419 ms) : 0, 284419
GlobalTracer [candidate] (283.142 ms) : 0, 283142
AppSec [baseline] (32.851 ms) : 0, 32851
AppSec [candidate] (32.816 ms) : 0, 32816
Debugger [baseline] (67.546 ms) : 0, 67546
Debugger [candidate] (67.325 ms) : 0, 67325
Remote Config [baseline] (648.694 µs) : 0, 649
Remote Config [candidate] (632.706 µs) : 0, 633
Telemetry [baseline] (9.245 ms) : 0, 9245
Telemetry [candidate] (9.148 ms) : 0, 9148
Flare Poller [baseline] (3.817 ms) : 0, 3817
Flare Poller [candidate] (3.672 ms) : 0, 3672
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (789.467 ms) : 0, 789467
BytebuddyAgent [candidate] (799.367 ms) : 0, 799367
GlobalTracer [baseline] (254.555 ms) : 0, 254555
GlobalTracer [candidate] (259.546 ms) : 0, 259546
IAST [baseline] (26.989 ms) : 0, 26989
IAST [candidate] (27.505 ms) : 0, 27505
AppSec [baseline] (33.435 ms) : 0, 33435
AppSec [candidate] (33.764 ms) : 0, 33764
Debugger [baseline] (66.172 ms) : 0, 66172
Debugger [candidate] (66.269 ms) : 0, 66269
Remote Config [baseline] (703.146 µs) : 0, 703
Remote Config [candidate] (577.859 µs) : 0, 578
Telemetry [baseline] (8.482 ms) : 0, 8482
Telemetry [candidate] (8.52 ms) : 0, 8520
Flare Poller [baseline] (3.536 ms) : 0, 3536
Flare Poller [candidate] (3.596 ms) : 0, 3596
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section baseline
no_agent (19.257 ms) : 19062, 19453
. : milestone, 19257,
appsec (18.81 ms) : 18619, 19000
. : milestone, 18810,
code_origins (17.668 ms) : 17493, 17844
. : milestone, 17668,
iast (17.944 ms) : 17765, 18123
. : milestone, 17944,
profiling (18.882 ms) : 18694, 19070
. : milestone, 18882,
tracing (17.689 ms) : 17514, 17863
. : milestone, 17689,
section candidate
no_agent (18.184 ms) : 18001, 18368
. : milestone, 18184,
appsec (19.016 ms) : 18825, 19206
. : milestone, 19016,
code_origins (17.537 ms) : 17360, 17715
. : milestone, 17537,
iast (17.694 ms) : 17519, 17868
. : milestone, 17694,
profiling (18.382 ms) : 18195, 18569
. : milestone, 18382,
tracing (17.544 ms) : 17367, 17722
. : milestone, 17544,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section baseline
no_agent (1.204 ms) : 1192, 1216
. : milestone, 1204,
iast (3.196 ms) : 3156, 3236
. : milestone, 3196,
iast_FULL (5.926 ms) : 5866, 5986
. : milestone, 5926,
iast_GLOBAL (3.627 ms) : 3573, 3681
. : milestone, 3627,
profiling (2.025 ms) : 2005, 2044
. : milestone, 2025,
tracing (1.81 ms) : 1795, 1826
. : milestone, 1810,
section candidate
no_agent (1.244 ms) : 1231, 1257
. : milestone, 1244,
iast (3.096 ms) : 3056, 3136
. : milestone, 3096,
iast_FULL (5.881 ms) : 5822, 5940
. : milestone, 5881,
iast_GLOBAL (3.605 ms) : 3547, 3662
. : milestone, 3605,
profiling (1.971 ms) : 1955, 1988
. : milestone, 1971,
tracing (1.781 ms) : 1766, 1796
. : milestone, 1781,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section baseline
no_agent (14.943 s) : 14943000, 14943000
. : milestone, 14943000,
appsec (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
iast (18.409 s) : 18409000, 18409000
. : milestone, 18409000,
iast_GLOBAL (17.611 s) : 17611000, 17611000
. : milestone, 17611000,
profiling (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
tracing (14.589 s) : 14589000, 14589000
. : milestone, 14589000,
section candidate
no_agent (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
appsec (14.459 s) : 14459000, 14459000
. : milestone, 14459000,
iast (18.224 s) : 18224000, 18224000
. : milestone, 18224000,
iast_GLOBAL (17.81 s) : 17810000, 17810000
. : milestone, 17810000,
profiling (14.884 s) : 14884000, 14884000
. : milestone, 14884000,
tracing (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~440fe505da, baseline=1.58.0-SNAPSHOT~8c047aa8b3
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.748 ms) : 3527, 3969
. : milestone, 3748,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.259 ms) : 2194, 2324
. : milestone, 2259,
profiling (2.085 ms) : 2030, 2139
. : milestone, 2085,
tracing (2.058 ms) : 2007, 2109
. : milestone, 2058,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.665 ms) : 3449, 3881
. : milestone, 3665,
iast (2.226 ms) : 2161, 2292
. : milestone, 2226,
iast_GLOBAL (2.258 ms) : 2192, 2323
. : milestone, 2258,
profiling (2.085 ms) : 2032, 2138
. : milestone, 2085,
tracing (2.057 ms) : 2005, 2109
. : milestone, 2057,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: akka
Akka instrumentation
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Creates diffrent instrumenter modules for tracing/iast/appsec
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]