Allow campaigner-automated-change label in PR validation#11311
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom May 7, 2026
Merged
Conversation
The PR label-validation workflow only accepts labels matching one of a small set of category prefixes (`type:`, `comp:`, `inst:`, `tag:`, ...). Labels applied by external automation (e.g. Campaigner) don't follow that scheme, so they trip the check and the PR gets a sticky blocking comment that requires a maintainer to remove. Add an explicit exact-match allowlist alongside the prefix list so known-good labels from automation tooling can pass without conflating the "category prefix" concept with "exact label name". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mhlidd
added
the
tag: ai generated
mhlidd
changed the title
campaigner-automated-change label in PR validation
mhlidd
added
type: enhancement
mhlidd
requested review from
AlexeyKuznetsov-DD and
sarahchen6
and removed request for
a team
sarahchen6
approved these changes
May 7, 2026
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 1129838
into
master
765 of 775 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
matthew.li/allow-campaigner-label
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds an exact-match allowlist to
.github/workflows/check-pull-request-labels.yamland includescampaigner-automated-changein it, so that label no longer fails the "Validate PR Label Format" check.The validation now passes a label if either:
type:,comp:,inst:,tag:,mergequeue-status:,team:,performance:,run-tests:), orexactAllowlistarray.Motivation
The
campaigner-automated-changelabel is applied by external automation (Campaigner) and doesn't fit any of the existing category prefixes. Without this change, every PR that automation labels triggers a sticky<!-- dd-trace-java-check-pr-labels-workflow -->blocking comment that a maintainer must manually delete to unblock the merge — even though the label itself is intentional and valid.A separate
exactAllowlist(rather than dropping the label name intovalidCategoriesdirectly) keeps the "category prefix" and "specific exempt label" concepts distinct, which is friendlier to future readers and makes it obvious where to add similar automation labels in the future.Additional Notes
exactAllowlistarray.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueJira ticket: N/A
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.