Skip to content

Fix a couple of IAST modules to use the IGSpanInfo in the event over the active span#11934

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/prefer-igspan-over-activespan
Jul 14, 2026
Merged

Fix a couple of IAST modules to use the IGSpanInfo in the event over the active span#11934
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/prefer-igspan-over-activespan

Conversation

@mcculls

@mcculls mcculls commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Motivation

Avoids use of activeSpan when the span is already available in the gateway event.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls requested a review from a team as a code owner July 13, 2026 17:33
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label Jul 13, 2026
@mcculls mcculls added type: refactoring comp: asm iast Application Security Management (IAST) labels Jul 13, 2026
@mcculls mcculls requested a review from jandro996 July 13, 2026 17:35

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up changes

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The cast (AgentSpan) igSpanInfo is safe for all production inputs: AgentSpan extends IGSpanInfo and no class in this codebase implements IGSpanInfo without also implementing AgentSpan (verified by exhaustive grep). Null is handled correctly — an NPE from igSpanInfo.getTags() on line 39 (before the cast on line 51) is swallowed by the existing catch (Throwable e) block, so the 'exception not thrown if igSpanInfo is null' test continues to pass. No behavioral regressions found.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 9965175 · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-official

datadog-official Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 79.99% (+22.94%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9965175 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.93 s [-0.1%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent 12.96 s 13.01 s [-1.2%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 16.88 s 16.05 s [+0.7%; +9.6%] (maybe worse)
startup:petclinic:iast:Agent 16.87 s 16.98 s [-1.5%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.49 s 16.73 s [-2.5%; -0.3%] (maybe better)
startup:petclinic:sca:Agent 16.92 s 16.86 s [-0.7%; +1.3%] (no difference)
startup:petclinic:tracing:Agent 16.09 s 16.24 s [-1.9%; -0.0%] (maybe better)

Commit: 9965175c · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls mcculls added this pull request to the merge queue Jul 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-14 12:43:01 UTC ℹ️ Start processing command /merge


2026-07-14 12:43:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-14 14:43:41 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 7085489522989408789 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

Possible reasons:

  • some mandatory checkruns are failing:
    • Check pull request labels
    • Check pull requests
    • Enforce Groovy migration

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@mcculls mcculls added this pull request to the merge queue Jul 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-14 14:44:06 UTC ℹ️ Start processing command /merge


2026-07-14 14:44:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-14 15:43:58 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit fbb45e7 into master Jul 14, 2026
589 of 595 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/prefer-igspan-over-activespan branch July 14, 2026 15:43
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants