Skip to content

Return non-null traceConfig from ExtractedSpan - #12413

Open
mcculls wants to merge 1 commit into
masterfrom
mcculls/avoid-extractedspan-npe
Open

Return non-null traceConfig from ExtractedSpan#12413
mcculls wants to merge 1 commit into
masterfrom
mcculls/avoid-extractedspan-npe

Conversation

@mcculls

@mcculls mcculls commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Provide a real implementation, in case anything queries an ExtractedSpan for the current trace config. Note this is the only agent span implementation that was returning an invalid value for traceConfig()

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added type: bug fix Bug fix comp: core Tracer core labels Sep 4, 2026
@datadog-official

This comment has been minimized.

@mcculls
mcculls marked this pull request as ready for review September 4, 2026 15:53
@mcculls
mcculls requested a review from a team as a code owner September 4, 2026 15:53
@mcculls
mcculls requested review from mhlidd and removed request for a team September 4, 2026 15:53
@dd-octo-sts dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Sep 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e17fffd660

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

datadog-official[bot]

This comment was marked as resolved.

Annotate AgentSpan.traceConfig() as non-null, migrate ExtractedSpanTest to JUnit 5

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mcculls
mcculls force-pushed the mcculls/avoid-extractedspan-npe branch from 8fd8a28 to 1632cd0 Compare September 4, 2026 16:05
@mcculls

mcculls commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@DataDog review

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

ExtractedSpan now returns the TraceConfig snapshot stored in TagContext and uses the current tracer config only when no snapshot exists. The new commit resolves the earlier configuration-drift finding, adds fallback coverage for empty and custom contexts, and leaves no open finding in the current PR.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 1632cd0 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.82 s 14.74 s [-0.3%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent 13.56 s 13.65 s [-1.6%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.18 s 16.84 s [+1.0%; +2.9%] (significantly worse)
startup:petclinic:iast:Agent 16.99 s 17.06 s [-1.1%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.89 s 16.92 s [-1.3%; +0.9%] (no difference)
startup:petclinic:sca:Agent 17.00 s 16.70 s [+0.9%; +2.6%] (maybe worse)
startup:petclinic:tracing:Agent 16.18 s 16.23 s [-1.3%; +0.6%] (no difference)

Commit: 1632cd0c · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls
mcculls enabled auto-merge September 4, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants