Return non-null traceConfig from ExtractedSpan - #12413
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e17fffd660
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
e17fffd to
8fd8a28
Compare
Annotate AgentSpan.traceConfig() as non-null, migrate ExtractedSpanTest to JUnit 5 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
8fd8a28 to
1632cd0
Compare
|
@DataDog review |
There was a problem hiding this comment.
More details
ExtractedSpan now returns the TraceConfig snapshot stored in TagContext and uses the current tracer config only when no snapshot exists. The new commit resolves the earlier configuration-drift finding, adds fallback coverage for empty and custom contexts, and leaves no open finding in the current PR.
🤖 Datadog Autotest · Commit 1632cd0 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Provide a real implementation, in case anything queries an
ExtractedSpanfor the current trace config. Note this is the only agent span implementation that was returning an invalid value fortraceConfig()Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]