update mysql image to support 8.4 lts#3372
Open
stephengroat-dd wants to merge 1 commit intoDataDog:masterfrom
Open
update mysql image to support 8.4 lts#3372stephengroat-dd wants to merge 1 commit intoDataDog:masterfrom
stephengroat-dd wants to merge 1 commit intoDataDog:masterfrom
Conversation
Collaborator
|
Hey, have you actually verified whether the old code which we test against properly works with the 8.4 mysql version? To test that, build the container, push it somewhere and change it here: dd-trace-php/.gitlab/generate-common.php Line 111 in 38ce35a (You have write access to this repository, by the way.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
moves
mysqlimage to a non-eol verisonReviewer checklist