Skip to content

Conversation

@cataphract
Copy link
Contributor

Description

  • Appsec helper submits per-service worker count
  • This all the other existing telemetry metrics that the helper generates are now submitted directly to sidecar, rather than going through the extension.

See also DataDog/libdatadog#1400

@cataphract cataphract requested review from a team as code owners December 12, 2025 18:45
@cataphract cataphract changed the base branch from master to glopes/appsec-abstract-ns December 12, 2025 18:45
@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from e8d6f32 to 1d00e73 Compare December 12, 2025 18:48
@cataphract cataphract changed the base branch from glopes/appsec-abstract-ns to master December 12, 2025 18:50
@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2026-01-23 18:50:40

Comparing candidate commit 41b2489 in PR branch glopes/sidecar-ffi-tel-metrics with baseline commit 4df27be in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6973d3b00000000076cdcb09be6972fd
tid: 6973d3b000000000
hexProcessTraceId: 76cdcb09be6972fd
hexProcessSpanId: ca03b2a838a44f1c
processTraceId: 8560721709410906877
processSpanId: 14556674856166117148

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6973d3b900000000b73e114c4fd5545c
tid: 6973d3b900000000
hexProcessTraceId: b73e114c4fd5545c
hexProcessSpanId: 2d607c2ceb92e3c2
processTraceId: 13204010176951440476
processSpanId: 3269749861843657666
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 66f3a64 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from 26633c8 to 6c240c5 Compare January 20, 2026 13:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 71.29630% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.03%. Comparing base (4df27be) to head (41b2489).

Files with missing lines Patch % Lines
appsec/src/helper/service.cpp 65.34% 24 Missing and 11 partials ⚠️
appsec/src/helper/service.hpp 71.69% 10 Missing and 5 partials ⚠️
appsec/src/helper/client.cpp 75.00% 2 Missing and 3 partials ⚠️
appsec/src/helper/client.hpp 87.50% 2 Missing and 2 partials ⚠️
appsec/src/helper/sidecar_settings.hpp 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (71.29%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3530      +/-   ##
==========================================
+ Coverage   62.01%   62.03%   +0.01%     
==========================================
  Files         140      140              
  Lines       13312    13364      +52     
  Branches     1762     1756       -6     
==========================================
+ Hits         8256     8290      +34     
- Misses       4267     4275       +8     
- Partials      789      799      +10     
Files with missing lines Coverage Δ
appsec/src/extension/commands/client_init.c 83.10% <ø> (+2.18%) ⬆️
appsec/src/extension/commands/request_shutdown.c 77.46% <100.00%> (+0.10%) ⬆️
appsec/src/extension/commands_helpers.c 69.23% <ø> (-1.58%) ⬇️
appsec/src/helper/engine.hpp 100.00% <100.00%> (ø)
appsec/src/helper/network/proto.hpp 93.22% <ø> (ø)
appsec/src/helper/telemetry.hpp 47.72% <ø> (ø)
appsec/src/helper/sidecar_settings.hpp 35.71% <0.00%> (-5.96%) ⬇️
appsec/src/helper/client.hpp 89.58% <87.50%> (-4.54%) ⬇️
appsec/src/helper/client.cpp 75.40% <75.00%> (-0.58%) ⬇️
appsec/src/helper/service.hpp 70.41% <71.69%> (+2.93%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df27be...41b2489. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-23 20:49:37

Comparing candidate commit 66f3a64 in PR branch glopes/sidecar-ffi-tel-metrics with baseline commit 4df27be in branch master.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 183 metrics, 5 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+6.086µs; +6.794µs] or [+6.042%; +6.746%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+7.854µs; +8.626µs] or [+7.952%; +8.733%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+95.302ns; +146.898ns] or [+8.262%; +12.735%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+99.310ns; +149.490ns] or [+8.633%; +12.995%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+69.256ns; +122.344ns] or [+5.848%; +10.331%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+88.157ns; +139.843ns] or [+7.645%; +12.127%]

@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from 1d1c8e1 to b4a6ce2 Compare January 23, 2026 14:40
@cataphract cataphract requested a review from a team as a code owner January 23, 2026 14:40
@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from b4a6ce2 to 41b2489 Compare January 23, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants