Use php_log_err() rather than _php_error_log_ex()#3551
Use php_log_err() rather than _php_error_log_ex()#3551Girgias wants to merge 1 commit intoDataDog:masterfrom
Conversation
|
Thanks @Girgias ❤️ |
|
Hey @Girgias, The problem is that this is a version agnostic zend_extension which we build once - and reuse across all versions (as you can see, it has version checks - and then loads the appropriate ddtrace.so). If this symbol gets removed on master, the proper fix is using dlsym stuff with disambiguation depending on version number. |
Description
I changed the signature of
_php_error_log()and removed_php_error_log_ex()on php-src@master and thinking of fully removing the exposed API as I can only find one other usage of it outside of dd-trace which is also always calling_php_error_log()with the same mode.So rather than doing effectively a function indirection call
php_log_err()directly (this is a compat macro on master, but my understanding is you support PHP 7.0 still)Reviewer checklist