Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 16, 2026

This PR implements this RFC for dynamic instrumentation.

Add process_tags to dynamic instrumentation payload.

This PR comes with this libdatadog PR: DataDog/libdatadog#1452 which justifies the temporary bump of libdatadog (to show that it works)

@datadog-official
Copy link

datadog-official bot commented Jan 16, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1026 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:60
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696f6a2a0000000092403239d7414ba1
tid: 696f6a2a00000000
hexProcessTraceId: 92403239d7414ba1
hexProcessSpanId: 8e5a93f6dcc4c96b
processTraceId: 10538478352052865953
processSpanId: 10257673789764847979
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 58d8f00 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-20 12:41:12

Comparing candidate commit 58d8f00 in PR branch dubloom/process-tags-di with baseline commit 617ba06 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics.

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+110.105ns; +147.095ns] or [+9.679%; +12.930%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+84.378ns; +130.622ns] or [+7.345%; +11.370%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+80.107ns; +134.893ns] or [+6.866%; +11.562%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+76.046ns; +134.554ns] or [+6.557%; +11.602%]

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.92%. Comparing base (617ba06) to head (58d8f00).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3580   +/-   ##
=======================================
  Coverage   61.92%   61.92%           
=======================================
  Files         140      140           
  Lines       13309    13309           
  Branches     1762     1762           
=======================================
  Hits         8241     8241           
  Misses       4278     4278           
  Partials      790      790           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617ba06...58d8f00. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from dubloom/process-tags to master January 19, 2026 12:07
@dubloom dubloom marked this pull request as ready for review January 19, 2026 12:07
@dubloom dubloom requested review from a team as code owners January 19, 2026 12:07
@dubloom dubloom force-pushed the dubloom/process-tags-di branch 2 times, most recently from 923101a to 3ce0af9 Compare January 20, 2026 09:27
@dubloom dubloom force-pushed the dubloom/process-tags-di branch from 793e2b6 to 58d8f00 Compare January 20, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants