Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 19, 2026

This PR implements this RFC for crashtracking.

Add process_tags to crashtracking tags

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 19, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696e231b00000000f672b36582324856
tid: 696e231b00000000
hexProcessTraceId: f672b36582324856
hexProcessSpanId: 60bc5a6ed6266813
processTraceId: 17758453529232689238
processSpanId: 6970545755348428819

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6f0ea77 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.91%. Comparing base (434d817) to head (6f0ea77).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
- Coverage   61.92%   61.91%   -0.01%     
==========================================
  Files         140      140              
  Lines       13309    13309              
  Branches     1762     1762              
==========================================
- Hits         8241     8240       -1     
- Misses       4278     4279       +1     
  Partials      790      790              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434d817...6f0ea77. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 19, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-19 13:15:55

Comparing candidate commit 6f0ea77 in PR branch dubloom/process-tags-crashtracking with baseline commit 434d817 in branch master.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 186 metrics, 1 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟥 execution_time [+356.896ns; +1243.104ns] or [+3.050%; +10.625%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+4.589µs; +6.131µs] or [+4.205%; +5.618%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+8.880µs; +9.600µs] or [+8.568%; +9.263%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+62.691ns; +145.709ns] or [+5.335%; +12.400%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+71.041ns; +116.359ns] or [+6.113%; +10.013%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+77.833ns; +125.567ns] or [+6.662%; +10.748%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+87.541ns; +151.659ns] or [+7.618%; +13.197%]

Base automatically changed from dubloom/process-tags to master January 19, 2026 12:07
@dubloom dubloom marked this pull request as ready for review January 19, 2026 12:09
@dubloom dubloom requested a review from a team as a code owner January 19, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants