Unbound - Supress subsession sudo -l shell output

[brettplarson]

What does this PR do?

This test_sudo line runs and the result code is used only to raise an exception. This PR pipes the output to /dev/null.

Motivation

I am making this change for two reasons:

1. It generates a lot of low value noise in the logs. This output doesn't appear to respect the log level, so it's impossible to turn this off.
2. Logging sudo -l output could potentially be a security risk, maybe a stretch, but i'm sure security would prefer you to not log this information.

Review checklist

• PR has a meaningful title or PR has the no-changelog label attached
• Feature or bugfix has tests
• Git history is clean
• If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
• If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

There's probably some other changes to this that could be explored, open to ideas, this just seemed like the quickest to get approved / merged.

Ideas:

• Rather than testing for sudo - why not just fail when sudo is used? this code seems overly complex. You need to explicitly enable use_sudo, why test every time?

[dkirov-dd]

Hey @brettplarson,

You can fix the failing test by bumping the minimum base check version to 37.20.0 in the pyproject.toml file.

[brettplarson]

@dbyron0 can you please review? thanks!

[dbyron0]

@dbyron0 can you please review? thanks!

I haven't used this code for a very long time. Fingers crossed there's someone who's been in the neighborhood more recently who can do a meaningful review.

[brettplarson]

@dkirov-dd can you please review? Thank you!

[github-actions]

This pull request has not been updated for more than 21 days. If there are no updates to this PR within 7 days, it will be closed. If you'd like to re-open this PR after it's been closed, you can start from the latest master branch or pull the latest changes into your branch and create a new pull request.

[github-actions]

This pull request was not updated after an additional 7 days of no activity. If you would like to continue work on this PR, please re-open this PR or create a fresh branch off of the latest master branch.