fix(network): Rephrase challenge fallback comment to avoid scanner false positive - #426
Merged
Merged
Conversation
The comment 'Fallback to session-level challenge if task-level not implemented' described working code — the fallback IS implemented. The automated scanner flagged 'not implemented' as a trigger phrase. Rephrase to accurately describe the working fallback delegation. Fixes #388 Co-authored-by: oh-my-pi <https://omp.sh>
DebugSwift: Coverage: 14.46
Generated by 🚫 Danger Swift against b8541b6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment on
HTTPProtocol.swift:806described working code — the session-level challenge fallback IS implemented. An automated scanner flagged "not implemented" as a placeholder trigger phrase (issue #388).Changes
Rephrase the comment to accurately describe the working fallback delegation without the scanner trigger phrase.
Test plan
xcodebuild buildsucceeds on iOS SimulatorFixes #388
Co-authored-by: oh-my-pi https://omp.sh