Enforce readonly name field for Test_Type instances and add dynamic serializer selection #14090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maffooch
requested review from
Jino-T,
blakeaowens,
paulOsinski and
valentijnscholten
valentijnscholten
approved these changes
Jan 15, 2026
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Can I suggest to ask AI to add a unit test to cover the "name is readonly" constraint?
Jino-T
approved these changes
Jan 15, 2026
paulOsinski
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement readonly constraints on the name field for existing Test_Type instances in forms and serializers. Introduce a new serializer for creating Test_Type instances and dynamically select the appropriate serializer in the viewset based on the action.
Also removed the tag serializer on the test type endpoint because test types dont have tags...
[sc-12484]