feat: add POST /api/cart/promo endpoint for promo-code discount#31
Open
samkerr4coding wants to merge 1 commit into
Open
feat: add POST /api/cart/promo endpoint for promo-code discount#31samkerr4coding wants to merge 1 commit into
samkerr4coding wants to merge 1 commit into
Conversation
…lation - Validates input with Zod (items, promoCode, region) - Calls existing totalize() from lib/cart.ts; no new business logic - Returns CartTotals + promoApplied boolean - Tests cover applyDiscount branches and route handler (valid, invalid, missing fields)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds POST /api/cart/promo — a stateless endpoint that accepts a cart and a promo code and returns the full CartTotals breakdown (subtotal, discount, tax, total) plus a promoApplied boolean.
Re-uses the existing otalize() and �pplyDiscount() functions from lib/cart.ts; no new business logic or DB queries.
Changes
Request / Response
\
POST /api/cart/promo
Content-Type: application/json
{
"items": [{ "productId": "p1", "quantity": 2, "unitPriceCents": 1000 }],
"promoCode": "WELCOME10",
"region": "GB"
}
HTTP 200
{
"totals": { "subtotalCents": 2000, "discountCents": 200, "taxCents": 360, "totalCents": 2160 },
"promoCode": "WELCOME10",
"promoApplied": true
}
\\
Checks
pm run lint\ — no warnings or errors
pm test\ — 21/21 tests pass (14 new)
Out of scope — noted for team
The following were intentionally excluded from this work item; a human should decide on priority: