-
Notifications
You must be signed in to change notification settings - Fork 663
Validator: Update validationCallback value parameter type (T1317117) #32092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+74
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fc59ee to
0d68cff
Compare
mpreyskurantov
approved these changes
Jan 9, 2026
0d68cff to
b808811
Compare
b808811 to
71ba64a
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the type annotation for the value parameter in validation callback functions from string | number to any across the DevExtreme library and its framework wrappers.
Changes:
- Updated JSDoc type annotations in
common.d.tsforAsyncRuleandCustomRuleto reflect that thevaluefield acceptsanytype - Regenerated Angular, React, and Vue wrapper files to reflect the updated type definition
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/common.d.ts | Updated JSDoc annotations for validationCallback value parameter in AsyncRule and CustomRule from string | number to any |
| packages/devextreme-vue/src/validator.ts | Regenerated Vue validator component with updated type for validationCallback value parameter |
| packages/devextreme-vue/src/tree-list.ts | Regenerated Vue tree-list component with updated type for validationCallback value parameter |
| packages/devextreme-vue/src/scheduler.ts | Regenerated Vue scheduler component with updated type for validationCallback value parameter |
| packages/devextreme-vue/src/form.ts | Regenerated Vue form component with updated type for validationCallback value parameter |
| packages/devextreme-vue/src/data-grid.ts | Regenerated Vue data-grid component with updated type for validationCallback value parameter |
| packages/devextreme-vue/src/card-view.ts | Regenerated Vue card-view component with updated type for validationCallback value parameter |
| packages/devextreme-react/src/validator.ts | Regenerated React validator component with updated type for validationCallback value parameter |
| packages/devextreme-react/src/tree-list.ts | Regenerated React tree-list component with updated type for validationCallback value parameter |
| packages/devextreme-react/src/scheduler.ts | Regenerated React scheduler component with updated type for validationCallback value parameter |
| packages/devextreme-react/src/form.ts | Regenerated React form component with updated type for validationCallback value parameter |
| packages/devextreme-react/src/data-grid.ts | Regenerated React data-grid component with updated type for validationCallback value parameter |
| packages/devextreme-react/src/card-view.ts | Regenerated React card-view component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/validator/nested/validation-rule-dxi.ts | Regenerated Angular validator validation-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/validator/nested/custom-rule-dxi.ts | Regenerated Angular validator custom-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/validator/nested/async-rule-dxi.ts | Regenerated Angular validator async-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/tree-list/nested/validation-rule-dxi.ts | Regenerated Angular tree-list validation-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/tree-list/nested/custom-rule-dxi.ts | Regenerated Angular tree-list custom-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/tree-list/nested/async-rule-dxi.ts | Regenerated Angular tree-list async-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/scheduler/nested/validation-rule-dxi.ts | Regenerated Angular scheduler validation-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/scheduler/nested/custom-rule-dxi.ts | Regenerated Angular scheduler custom-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/scheduler/nested/async-rule-dxi.ts | Regenerated Angular scheduler async-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/form/nested/validation-rule-dxi.ts | Regenerated Angular form validation-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/form/nested/custom-rule-dxi.ts | Regenerated Angular form custom-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/form/nested/async-rule-dxi.ts | Regenerated Angular form async-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/data-grid/nested/validation-rule-dxi.ts | Regenerated Angular data-grid validation-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/data-grid/nested/custom-rule-dxi.ts | Regenerated Angular data-grid custom-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/data-grid/nested/async-rule-dxi.ts | Regenerated Angular data-grid async-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/card-view/nested/validation-rule-dxi.ts | Regenerated Angular card-view validation-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/card-view/nested/custom-rule-dxi.ts | Regenerated Angular card-view custom-rule component with updated type for validationCallback value parameter |
| packages/devextreme-angular/src/ui/card-view/nested/async-rule-dxi.ts | Regenerated Angular card-view async-rule component with updated type for validationCallback value parameter |
marker-dao
approved these changes
Jan 12, 2026
r-farkhutdinov
added a commit
to r-farkhutdinov/DevExtreme
that referenced
this pull request
Jan 12, 2026
…evExpress#32092) Co-authored-by: Ruslan Farkhutdinov <[email protected]>
r-farkhutdinov
added a commit
to r-farkhutdinov/DevExtreme
that referenced
this pull request
Jan 12, 2026
…evExpress#32092) Co-authored-by: Ruslan Farkhutdinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.