fix(nx-infra-plugin): support spaces in workspace path#33514
Open
chaosmirage wants to merge 3 commits into26_1from
Open
fix(nx-infra-plugin): support spaces in workspace path#33514chaosmirage wants to merge 3 commits into26_1from
chaosmirage wants to merge 3 commits into26_1from
Conversation
chaosmirage
force-pushed
the
fix/nx-infra-build
branch
from
2cdf646 to
5fc3359
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the nx-infra-plugin postinstall/build script to correctly compile the plugin when the workspace path contains spaces, by avoiding shell command invocation for tsc and compiling via the TypeScript API instead.
Changes:
- Replaced
execSync('pnpm exec tsc -p ...')with a programmatic TypeScript compilation usingtypescriptAPIs. - Removed temporary bootstrap
tsconfiggeneration/cleanup logic and compile directly fromtsconfig.lib.json. - Added diagnostic formatting to provide readable compiler error output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.