Skip to content

GridCommands: implement column and summary commands#33520

Merged
anna-shakhova merged 8 commits intoDevExpress:26_1from
anna-shakhova:26_1__commands_columns
May 8, 2026
Merged

GridCommands: implement column and summary commands#33520
anna-shakhova merged 8 commits intoDevExpress:26_1from
anna-shakhova:26_1__commands_columns

Conversation

@anna-shakhova
Copy link
Copy Markdown
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this May 7, 2026
Copilot AI review requested due to automatic review settings May 7, 2026 13:46
@anna-shakhova anna-shakhova requested a review from a team as a code owner May 7, 2026 13:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the grid AI assistant command surface by adding column-manipulation commands at the grid-core level and summary-configuration commands for DataGrid, along with Jest coverage for the new behaviors.

Changes:

  • Added GridCore AI assistant commands to show/hide, reorder, pin/unpin, and resize columns (+ Jest tests).
  • Added DataGrid AI assistant commands to configure/clear summary (+ Jest tests) and introduced a shared Column intersection type for DataGrid commands.
  • Extended InternalGridOptions typing to include the summary option.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/m_types.ts Adds summary to the internal option typing so option('summary', …) is type-safe.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts Removes explanatory comments (no functional change).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/columns.ts Introduces column visibility/reorder/pinning/resize commands.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/columns.test.ts Adds Jest coverage for the new column commands.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/types.ts Adds shared DataGrid command Column type alias.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/summary.ts Introduces summary and clearSummary commands.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/grouping.ts Refactors to reuse the shared Column type.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/tests/summary.test.ts Adds Jest coverage for summary commands.

Copilot AI review requested due to automatic review settings May 7, 2026 15:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copilot AI review requested due to automatic review settings May 8, 2026 07:32
@anna-shakhova anna-shakhova force-pushed the 26_1__commands_columns branch from 133882a to e1841ec Compare May 8, 2026 07:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@anna-shakhova anna-shakhova force-pushed the 26_1__commands_columns branch from e1841ec to 441e8f7 Compare May 8, 2026 07:44
Copilot AI review requested due to automatic review settings May 8, 2026 10:40
@anna-shakhova anna-shakhova force-pushed the 26_1__commands_columns branch from 441e8f7 to a7175ed Compare May 8, 2026 10:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copilot AI review requested due to automatic review settings May 8, 2026 11:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

dmirgaev
dmirgaev previously approved these changes May 8, 2026
@anna-shakhova anna-shakhova merged commit d4b2012 into DevExpress:26_1 May 8, 2026
128 of 129 checks passed
@anna-shakhova anna-shakhova deleted the 26_1__commands_columns branch May 8, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants