fix(dgw): support network drives and UNC paths for recording storage space on Windows#1729
Merged
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom Mar 27, 2026
Merged
fix(dgw): support network drives and UNC paths for recording storage space on Windows#1729Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
Conversation
…space on Windows Issue: DGW-354
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Devolutions Gateway’s heartbeat recording-storage health reporting to correctly determine disk space on Windows when the recording path is on a UNC share or mapped network drive (DGW-354).
Changes:
- Refactors disk space lookup into
query_storage_space, usingGetDiskFreeSpaceExWon Windows andsysinfomount-point matching elsewhere. - Improves “no disk space” logging by including a short failure reason and reducing repeated WARN noise.
- Adds basic tests for writable temp dirs and nonexistent paths; introduces
tempfilefor test setup.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| devolutions-gateway/src/api/heartbeat.rs | Implements Windows-specific free-space query via GetDiskFreeSpaceExW, refactors storage querying, updates logging, adds tests. |
| devolutions-gateway/Cargo.toml | Adds windows-sys (Windows-only) and tempfile (dev-dependency) needed by the new code/tests. |
| Cargo.lock | Updates lockfile for the newly added dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: DGW-354