Support skip-signed portable signing#28
Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits intoJun 30, 2026
Merged
Support skip-signed portable signing#28Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
Conversation
Add digest-verified skip-signed handling for native-shaped portable PE/WinMD signing across cert-store, Azure Key Vault, and Artifact Signing flows. Unsigned files continue through normal signing, valid existing signatures are skipped, and corrupt existing PE signatures surface verification errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Marc-André Moreau (mamoreau-devolutions)
merged commit 003562c
into
master
36 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
mamoreau-devolutions-psign-skip-signed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-signedbehavior for portable PE/WinMD signing so valid embedded signatures are skipped, unsigned files sign normally, and corrupt existing signatures fail instead of being silently skipped.Set-PsignSignature -SkipSigned, including output-path copy behavior for skipped PE/WinMD files.Validation
cargo fmt --allcargo clippy --workspace --all-targets --lockedbash scripts/linux-portable-validation.shcargo test -p psign-portable-core --lockedcargo test --test cert_store_cli portable_sign_sha1_skip_signed --lockedpwsh ./PowerShell/build.ps1 -Configuration DebugSet-PsignSignature -SkipSignedKnown baseline issue:
cargo test --workspace --lockedstill fails intests/fixture_vector_manifest.rsdue the pre-existing size mismatch fortests/fixtures/msix-minimal/AppxManifest.xml(1418vs expected1452). Pester was not run because Pester 5.x is not installed in this environment.