Improvements to app shell components#55
Draft
douglaswinter wants to merge 12 commits into
Draft
Conversation
text.secondary when open, with text.primary label, and text.primary when closed.
zoharma
reviewed
Jun 5, 2026
| component={NavLink as React.ElementType} | ||
| to={route.path} | ||
| sx={{ | ||
| borderRadius: 1, |
Collaborator
There was a problem hiding this comment.
This is not working when applied to the ListItemButton. We need to wrap it in a box like so:
<ListItem disablePadding sx={{ mb: 0.5 }}>
<Box
sx={{
width: "100%",
borderRadius: 2,
overflow: "hidden",
}}
>
<ListItemButton
...
</ListItemButton>
</Box>
</ListItem>
Collaborator
Author
There was a problem hiding this comment.
What do you mean it is not working? I can definitely see the rounded corners and they change with response with this value. What should the radius be? In your design it says 8 which is spacing of 1. Happy to change it to 2 if it looks better
Collaborator
There was a problem hiding this comment.
Yes, not sure it wasn't sure until I added a box wrapper. But seems fine now.
douglaswinter
force-pushed
the
dw/appshellimprovements
branch
from
June 8, 2026 13:32
3c7e22b to
9eae422
Compare
Collaborator
|
@douglaswinter I think we could add a spacing of |
AppBar now has 0 elevation and a bottom border. Typography and menu button is brand colour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.