Add devcontainer for development - #110
Merged
Merged
Conversation
ZohebShaikh
marked this pull request as ready for review
August 4, 2026 12:02
ZohebShaikh
force-pushed
the
add-devcontainer
branch
from
August 4, 2026 12:03
1666039 to
2147e5b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 54.26% 54.26%
=======================================
Files 14 14
Lines 774 774
=======================================
Hits 420 420
Misses 354 354 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tpoliaw
changed the title
tpoliaw
approved these changes
Aug 4, 2026
tpoliaw
left a comment
tpoliaw
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure what is needed in a devcontainer but as long as it's not required, go for it.
| } | ||
| }, | ||
| "runArgs": [ | ||
| // Allow the container to access the host X11 display and EPICS CA |
Contributor
There was a problem hiding this comment.
Does glazed need x11 or epics?
Contributor
Author
There was a problem hiding this comment.
This is for when you run cargo serve you can access it outside
| "--security-opt=label=disable" | ||
| ], | ||
| "workspaceMount": "source=${localWorkspaceFolder}/..,target=/workspaces,type=bind", | ||
| "postStartCommand": "rustup component add --toolchain nightly-x86_64-unknown-linux-gnu rustfmt && rustup component add clippy" |
Contributor
There was a problem hiding this comment.
Is the full triple needed or is --toolchain nightly enough?
Contributor
Author
There was a problem hiding this comment.
you would still need clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add devcontainer to make it easier to work on diamond machines