Skip to content

Added plan to i23 init#1707

Draft
adaudon wants to merge 5 commits into
mainfrom
1706-Optical_Centering
Draft

Added plan to i23 init#1707
adaudon wants to merge 5 commits into
mainfrom
1706-Optical_Centering

Conversation

@adaudon

@adaudon adaudon commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #1706

Link to dodal PR (if required): DiamondLightSource/dodal#2023
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@adaudon adaudon requested a review from a team as a code owner April 23, 2026 13:52
@adaudon adaudon added the i23 Changes relating to I23 label Apr 23, 2026
@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.82%. Comparing base (b63552a) to head (29b638a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
- Coverage   92.84%   92.82%   -0.03%     
==========================================
  Files         156      158       +2     
  Lines        8557     8570      +13     
==========================================
+ Hits         7945     7955      +10     
- Misses        612      615       +3     
Components Coverage Δ
i24 SSX 77.15% <ø> (ø)
hyperion 98.65% <ø> (ø)
other 98.24% <78.57%> (-0.08%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adaudon adaudon marked this pull request as draft June 10, 2026 09:17
@adaudon adaudon force-pushed the 1706-Optical_Centering branch from 2c20a9a to 0a2737f Compare June 23, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i23 Changes relating to I23

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement optical centering for I23

1 participant