Skip to content

1587 Fix use_roi_mode option in mx-bluesky#1776

Merged
rtuck99 merged 9 commits into
mainfrom
1587_obey_roi_mode
Jun 25, 2026
Merged

1587 Fix use_roi_mode option in mx-bluesky#1776
rtuck99 merged 9 commits into
mainfrom
1587_obey_roi_mode

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fixes

Requires:

Link to dodal PR (if required): #N/A

(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Hyperion honours the gda.mx.hyperion.xrc.use_roi_mode property in domain.properties for Xray centring. For rotations behaviour is unchanged and uses the full frame.

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 force-pushed the 1587_obey_roi_mode branch from 4bbce64 to bcc0e02 Compare June 19, 2026 12:50
@rtuck99 rtuck99 added the hyperion Issues for Hyperion, the Bluesky UDC stack label Jun 19, 2026
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (9e17b58) to head (990c744).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         164      164           
  Lines        8924     8927    +3     
=======================================
+ Hits         8302     8305    +3     
  Misses        622      622           
Components Coverage Δ
i24 SSX 77.16% <ø> (ø)
hyperion 98.74% <100.00%> (+<0.01%) ⬆️
other 98.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review June 19, 2026 14:46
@rtuck99 rtuck99 requested a review from a team as a code owner June 19, 2026 14:46
@rtuck99 rtuck99 changed the title Initial fix for roi mode 1587 Fix use_roi_mode option in mx-bluesky Jun 22, 2026

@phathaway phathaway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets issue spec

@rtuck99 rtuck99 enabled auto-merge (squash) June 25, 2026 10:27
@rtuck99 rtuck99 merged commit bff8d34 into main Jun 25, 2026
15 of 16 checks passed
@rtuck99 rtuck99 deleted the 1587_obey_roi_mode branch June 25, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hyperion Issues for Hyperion, the Bluesky UDC stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants