Skip to content

1756 nexus generates wrong omega multipin - #1784

Merged
rtuck99 merged 10 commits into
mainfrom
1756_nexus_generates_wrong_omega_multipin
Sep 2, 2026
Merged

rtuck99 merged 10 commits into
mainfrom
1756_nexus_generates_wrong_omega_multipin

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jun 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes

Note: system tests are currently skipped (it is currently not certain whether changes to imginfo are required or whether the warnings will be fixed at some point in future), imginfo raises warnings due to it not liking decreasing omega.

The fix should now result in the rotation_direction parameter in the hyperion request being applied to the omega values in the generated nexus files instead of them always increasing.

(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Nexus files are generated with correct omega metadata in forwards and backwards directions
  2. System tests pass (when above imginfo fix is applied)

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 added the hyperion Issues for Hyperion, the Bluesky UDC stack label Jul 14, 2026
@rtuck99
rtuck99 force-pushed the 1756_nexus_generates_wrong_omega_multipin branch from 18ec48a to de2d48d Compare July 14, 2026 13:58
@rtuck99
rtuck99 marked this pull request as ready for review July 14, 2026 14:32
@rtuck99
rtuck99 requested a review from a team as a code owner July 14, 2026 14:32
@rtuck99
rtuck99 force-pushed the 1756_nexus_generates_wrong_omega_multipin branch from 311c6ec to d92a879 Compare August 5, 2026 09:37
@codecov

codecov Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.09%. Comparing base (8b80655) to head (dabe14a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1784   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         164      164           
  Lines        8985     8985           
=======================================
  Hits         8365     8365           
  Misses        620      620           
Components Coverage Δ
i24 SSX 77.13% <ø> (ø)
hyperion 98.77% <ø> (ø)
other 98.23% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scan.omega_start_deg,
scan.omega_start_deg
+ ((scan.num_images - 1) * multi_params.rotation_increment_deg),
+ (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit / Should :

This has been ( originally ) written to cause the reader max double vision

a much neater version would be something like

assert len(omega) = scan.num_images # same ie just to place this snippet
delta_deg = (scan.num_images - 1)
* multi_params.rotation_increment_deg
* scan.rotation_direction.multiplier
omeg_end_deg = delta_deg + scan.omega_start_deg
expected = np.linspace(scan.omega_start_deg, omega_end_deg, scan.num_images)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made it and the following slightly clearer

@rtuck99
rtuck99 force-pushed the 1756_nexus_generates_wrong_omega_multipin branch from 7366fcc to bae339c Compare August 11, 2026 10:23
@rtuck99
rtuck99 enabled auto-merge (squash) September 2, 2026 15:18
@rtuck99
rtuck99 disabled auto-merge September 2, 2026 15:19
@rtuck99
rtuck99 enabled auto-merge (squash) September 2, 2026 15:19
@rtuck99
rtuck99 merged commit 253c9bd into main Sep 2, 2026
16 checks passed
@rtuck99
rtuck99 deleted the 1756_nexus_generates_wrong_omega_multipin branch September 2, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hyperion Issues for Hyperion, the Bluesky UDC stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants