Repository navigation
1756 nexus generates wrong omega multipin - #1784
Merged
Merged
Conversation
rtuck99
force-pushed
the
1756_nexus_generates_wrong_omega_multipin
branch
from
July 14, 2026 13:58
18ec48a to
de2d48d
Compare
rtuck99
marked this pull request as ready for review
July 14, 2026 14:32
rtuck99
force-pushed
the
1756_nexus_generates_wrong_omega_multipin
branch
from
August 5, 2026 09:37
311c6ec to
d92a879
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1784 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 164 164
Lines 8985 8985
=======================================
Hits 8365 8365
Misses 620 620
🚀 New features to boost your workflow:
|
CoePaul
reviewed
Aug 5, 2026
| scan.omega_start_deg, | ||
| scan.omega_start_deg | ||
| + ((scan.num_images - 1) * multi_params.rotation_increment_deg), | ||
| + ( |
Contributor
There was a problem hiding this comment.
Nit / Should :
This has been ( originally ) written to cause the reader max double vision
a much neater version would be something like
assert len(omega) = scan.num_images # same ie just to place this snippet
delta_deg = (scan.num_images - 1)
* multi_params.rotation_increment_deg
* scan.rotation_direction.multiplier
omeg_end_deg = delta_deg + scan.omega_start_deg
expected = np.linspace(scan.omega_start_deg, omega_end_deg, scan.num_images)
Contributor
Author
There was a problem hiding this comment.
I've made it and the following slightly clearer
CoePaul
reviewed
Aug 5, 2026
rtuck99
force-pushed
the
1756_nexus_generates_wrong_omega_multipin
branch
from
August 11, 2026 10:23
7366fcc to
bae339c
Compare
CoePaul
approved these changes
Sep 2, 2026
rtuck99
enabled auto-merge (squash)
September 2, 2026 15:18
rtuck99
disabled auto-merge
September 2, 2026 15:19
rtuck99
enabled auto-merge (squash)
September 2, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Note: system tests are currently skipped (it is currently not certain whether changes to imginfo are required or whether the warnings will be fixed at some point in future), imginfo raises warnings due to it not liking decreasing omega.
The fix should now result in the
rotation_directionparameter in the hyperion request being applied to the omega values in the generated nexus files instead of them always increasing.(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
System tests pass (when aboveimginfofix is applied)Checks for reviewer