Add ispyb inserts for SXT atlases and ROIs#840
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 53.31% 52.93% -0.38%
==========================================
Files 101 102 +1
Lines 10933 11279 +346
Branches 1452 1572 +120
==========================================
+ Hits 5829 5971 +142
- Misses 4788 4959 +171
- Partials 316 349 +33 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jul 13, 2026
tieneupin
requested changes
Jul 13, 2026
tieneupin
left a comment
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
One typo'ed attribute that needs fixing, and some optional suggestions.
tieneupin
approved these changes
Jul 14, 2026
tieneupin
left a comment
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing my comments! This should be good to merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the functionality to insert SXT atlas and ROI images into both the murfey and ispyb databases. For ispyb the positions are adjusted to match the thumbnail images so that they display correctly on pato.
Requires atlas locations which weren't previously needed, so makes use of the
ImagingSitetable in addition toDataCollectionGroup. ROIs are inserted into theSearchMaptable (matching GridSquare in ispyb).Relatively low test coverage as I haven't written tests for the ispyb inserts.