Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Replace the metadata check in test_boilerplate_removed.py #144

Description

@coretl

This line is problematic:

summary = metadata("python3-pip-skeleton")["summary"]

First of all it needs the name of the module, which created DiamondLightSource/python3-pip-skeleton-cli#85, also it needs you to reinstall after fixing the issue in editable mode, which will trip people up. I suggest we go back to the less robust but simpler approach of:

def test_module_summary():
    assert_not_contains_text(
        "pyproject.toml",
        "One line description of your module",
        "so [project] description is a one line description of your module",
    )

@garryod thoughts?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions