Conversation
added 3 commits
January 26, 2026 23:18
…only empty strings, by working on the input dataframe and not an empty dataframe
…tions and to allow working around issues with pandas csv parsing and writing
Collaborator
Author
|
Should something be mentioned in the CHANGELOG? If we merge this, the only user visible changes will be the slightly adjusted example, the "support" for python 3.11 and some type annotation improvements. The CSV changes are in that sense no new features or behavior changes, more fixes to achieve the expected behavior in various 'edge' cases. |
buddemat
reviewed
Jan 30, 2026
buddemat
reviewed
Feb 2, 2026
buddemat
requested changes
Feb 2, 2026
Collaborator
buddemat
left a comment
buddemat
left a comment
There was a problem hiding this comment.
I have 2 comments concerning performance, whcih I guess should be addressed. I have not looked at the tests.
From what I read in the channels, both @julianjanssen and @ArneBab see some issues with the "full custom csv import" approach. We might want to discuss this once more?
added 7 commits
February 5, 2026 09:38
…ead of custom reader
…ending on version
… to utc to have a stable output, always have pandas Timestamps and prevent issues with mixed timezone offsets
…rted and attempt to lower required version to 3.10
added 2 commits
February 5, 2026 13:26
…about the cadenza server timezone, use the python server timezone as fallback
ArneBab
reviewed
Feb 11, 2026
Collaborator
|
Ok, I'm merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.