[Feat] BGE-M3 배치 문서 임베딩 연동 지원 추가 구현 - #102
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughPython Embedding Server에 ChangesBGE-M3 배치 문서 임베딩
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DocumentEmbeddingGenerator
participant EmbeddingClient
participant EmbeddingServer
DocumentEmbeddingGenerator->>EmbeddingClient: embedBatch(chunks, batchSize)
EmbeddingClient->>EmbeddingServer: POST /embed/batch
EmbeddingServer-->>EmbeddingClient: model, indexed vectors
EmbeddingClient-->>DocumentEmbeddingGenerator: validated batch response
DocumentEmbeddingGenerator-->>DocumentEmbeddingGenerator: validate vectors and create drafts
Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
/embed단건 계약을 유지하면서 문서 Chunk 전용/embed/batchAPI를 추가했습니다.embedding.document.batch-size로 설정하고 1~64 범위를 검증합니다.Closes #101
상세 설명
문서 Chunk 수만큼 반복되던 HTTP 및 BGE-M3 호출을 설정 가능한 Batch 단위로 줄였습니다.
EmbeddingWork에 Model Name을 고정해 준비와 완료 Transaction 사이의 모델 변경도 차단합니다.Query Embedding의 기존 단건 API와 응답 형식은 변경하지 않으며, Provider 전송 장애는 기존 Worker 자동 Retry 정책을 사용합니다.
검증
BAAI/bge-m3Batch Smoke문서
docs/design/Gimini-3-#101-bge-m3-batch-document-embedding.mddocs/test-results/Gimini-3-#101-bge-m3-batch-document-embedding.md추후 작업
Summary by CodeRabbit
새 기능
버그 수정
문서화