[Feat] 문서 인덱싱 완료 및 검색 가능 Version 전환 - #87
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
📝 WalkthroughWalkthrough문서 인덱싱 완료 API와 완료 서비스를 추가했다. 서비스는 실행 소유권과 Embedding Set을 검증한 뒤 Job, Attempt, Version, Document, Embedding, 이벤트를 하나의 Transaction으로 전환한다. 동일 실행의 재요청은 저장된 완료 결과를 재생한다. Changes문서 인덱싱 완료
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Admin
participant IndexingJobAdminController
participant DocumentIndexingCompletionService
participant Database
Admin->>IndexingJobAdminController: 완료 요청 전송
IndexingJobAdminController->>DocumentIndexingCompletionService: complete 호출
DocumentIndexingCompletionService->>Database: Job, Version, Document 잠금 및 검증
DocumentIndexingCompletionService->>Database: 상태 전환, Embedding 갱신, INDEXED 이벤트 저장
Database-->>DocumentIndexingCompletionService: 완료 결과 반환
DocumentIndexingCompletionService-->>IndexingJobAdminController: 완료 응답 반환
IndexingJobAdminController-->>Admin: 200 OK
Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍️ 작업 내용
POST /admin/indexing-jobs/{jobId}/attempts/{attemptId}/completeSUCCESS, Job/Version/Document를INDEXED로 전환Closes #84
✨ 상세 설명
✅ 검증
./gradlew clean buildgit diff --check📚 문서
docs/design/Gimini-3-#84-document-indexing-completion.mddocs/test-results/Gimini-3-#84-document-indexing-completion.md💬 리뷰 요구사항
Summary by CodeRabbit
새로운 기능
개선 사항
검증