[Feat] 모든 비즈니스 로직에 BDD 기반 테스트 구축

.github/workflows/debug.yml

@@ -65,6 +65,9 @@ jobs:
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
 
+    - name: Run unit tests (required)
+      run: ./gradlew :app:testDebugUnitTest :core:common:testDebugUnitTest
+
     # - name: Assemble Debug APK
     #   if: >
     #     github.event_name == 'pull_request' &&

app/build.gradle.kts

@@ -135,6 +135,12 @@ android {
     lint {
         abortOnError = false
     }
+
+    testOptions {
+        unitTests.all {
+            it.useJUnitPlatform()
+        }
+    }
 }
 
 dependencies {
@@ -181,6 +187,12 @@ dependencies {
 
     // Testing libraries
     testImplementation(libs.junit)
+    testImplementation(libs.kotest.runner.junit5)
+    testImplementation(libs.kotest.assertions.core)
+    testImplementation(libs.kotest.property)
+    testImplementation(libs.mockk)
+    testImplementation(libs.kotlinx.coroutines.test)
+    testImplementation(libs.turbine)
     androidTestImplementation(libs.androidx.test.ext.junit)
     androidTestImplementation(libs.androidx.espresso.core)
 

app/src/main/java/com/eatssu/android/data/remote/repository/ReviewRepositoryImpl.kt

@@ -61,9 +61,9 @@ class ReviewRepositoryImpl @Inject constructor(private val reviewService: Review
             rating = rating,
             content = content,
             imageUrls = imageUrls,
-            menuLike = likeMenuIdList?.let {
+            menuLike = likeMenuIdList?.firstOrNull()?.let {
                 WriteMenuReviewRequest.MenuLike(
-                    menuId = it.first(),
+                    menuId = it,
                     isLike = true,
                 )
             }

app/src/main/java/com/eatssu/android/di/AppModule.kt

@@ -6,6 +6,7 @@ import dagger.Module
 import dagger.Provides
 import dagger.hilt.InstallIn
 import dagger.hilt.components.SingletonComponent
+import java.time.Clock
 import javax.inject.Singleton
 
 @Module
@@ -17,4 +18,8 @@ object AppModule {
     fun provideContext(application: Application): Context {
         return application.applicationContext
     }
+
+    @Provides
+    @Singleton
+    fun provideClock(): Clock = Clock.systemDefaultZone()
 }

app/src/main/java/com/eatssu/android/di/network/ApiResultCall.kt

@@ -76,17 +76,19 @@ class ApiResultCall<T : Any>(
                         )
 
                     // BaseResponse 형태인지 확인 (isSuccess가 false이고 code와 message가 있는 경우)
-                    if (errorResponse.isSuccess == false &&
-                        errorResponse.code != null &&
-                        errorResponse.message != null
-                    ) {
+                    if (errorResponse.isSuccess == false) {
+                        val parsedCode = errorResponse.code
+                        val parsedMessage = errorResponse.message
 
-                        Timber.d("ApiResultCall - Parsed error response: ${errorResponse.code} - ${errorResponse.message}")
+                        if (parsedCode != null && !parsedMessage.isNullOrBlank()) {
 
-                        return ApiResult.Failure(
-                            errorResponse.code!!,
-                            errorResponse.message
-                        )
+                            Timber.d("ApiResultCall - Parsed error response: $parsedCode - $parsedMessage")
+
+                            return ApiResult.Failure(
+                                parsedCode,
+                                parsedMessage
+                            )
+                        }
                     }
                 } catch (e: Exception) {
                     Timber.w(e, "ApiResultCall - Failed to parse errorBody as BaseResponse")

app/src/main/java/com/eatssu/android/domain/usecase/alarm/AlarmUsecase.kt

@@ -7,10 +7,12 @@ import android.content.Intent
 import com.eatssu.android.alarm.NotificationReceiver
 import dagger.hilt.android.qualifiers.ApplicationContext
 import java.util.Calendar
+import java.time.Clock
 import javax.inject.Inject
 
 class AlarmUseCase @Inject constructor(
     @ApplicationContext private val context: Context,
+    private val clock: Clock,
 ) {
 
     fun scheduleAlarm() {
@@ -21,13 +23,14 @@ class AlarmUseCase @Inject constructor(
         )
 
         val calendar = Calendar.getInstance().apply {
+            timeInMillis = clock.millis()
             set(Calendar.HOUR_OF_DAY, 11)
             set(Calendar.MINUTE, 0)
             set(Calendar.SECOND, 0)
             set(Calendar.MILLISECOND, 0)
         }
 
-        if (calendar.timeInMillis <= System.currentTimeMillis()) {
+        if (calendar.timeInMillis <= clock.millis()) {
             calendar.add(Calendar.DAY_OF_YEAR, 1)
         }
 

app/src/main/java/com/eatssu/android/domain/usecase/user/SetUserNicknameUseCase.kt

@@ -22,8 +22,11 @@ class SetUserNicknameUseCase @Inject constructor(
     private val accountDataStore: AccountDataStore
 ) {
     suspend operator fun invoke(nickname: String): Result<Unit> {
-        // 로컬 저장
-        accountDataStore.setName(nickname)
-        return userRepository.updateUserName(ChangeNicknameRequest(nickname))
+        val result = userRepository.updateUserName(ChangeNicknameRequest(nickname))
+        if (result.isSuccess) {
+            // 서버 닉네임 변경이 성공한 경우에만 로컬 닉네임 변경
+            accountDataStore.setName(nickname)
+        }
+        return result
     }
-}
+}

app/src/main/java/com/eatssu/android/presentation/MainViewModel.kt

@@ -41,9 +41,11 @@ class MainViewModel @Inject constructor(
     val uiEvent: SharedFlow<UiEvent> = _uiEvent
 
     init {
-        loadStoredUserDepartment()
-        getUserDepartment()
-        fetchAndCheckNickname()
+        viewModelScope.launch {
+            loadStoredUserDepartment()
+            getUserDepartment()
+            fetchAndCheckNickname()
+        }
     }
 
     fun refreshUserDepartment() {
@@ -57,21 +59,12 @@ class MainViewModel @Inject constructor(
         }
     }
 
-    private fun fetchAndCheckNickname() {
-        viewModelScope.launch {
-            _uiState.value = UiState.Loading
-
-            val nickname = getUserNickNameUseCase()
-
-            // 1) 닉네임 없음
-            if (nickname.isBlank()) {
-                _uiState.value = UiState.Success(MainState.NicknameNull)
-                _uiEvent.emit(UiEvent.ShowToast(UiText.StringResource(R.string.set_nickname), ToastType.ERROR))
-                return@launch
-            }
+    private suspend fun fetchAndCheckNickname() {
+        val nickname = getUserNickNameUseCase()
 
-            // 2) 정상 닉네임
-            _uiState.value = UiState.Success(MainState.NicknameExists(nickname))
+        if (nickname.isBlank()) {
+            _uiState.value = UiState.Success(MainState.NicknameNull)
+            _uiEvent.emit(UiEvent.ShowToast(UiText.StringResource(R.string.set_nickname), ToastType.ERROR))
         }
     }
 
@@ -99,49 +92,44 @@ class MainViewModel @Inject constructor(
         return data
     }
 
-    private fun loadStoredUserDepartment() {
-        viewModelScope.launch {
-            val userInfo = getUserCollegeDepartmentUseCase()
-            _uiState.value = UiState.Success(
-                MainState.DepartmentState(
-                    departmentName = userInfo.userDepartment.departmentName,
-                    showUserDepartmentBottomSheet =
-                        (userInfo.userCollege.collegeId == -1 || userInfo.userDepartment.departmentId == -1)
-                )
+    private suspend fun loadStoredUserDepartment() {
+        val userInfo = getUserCollegeDepartmentUseCase()
+        _uiState.value = UiState.Success(
+            MainState.DepartmentState(
+                departmentName = userInfo.userDepartment.departmentName,
+                showUserDepartmentBottomSheet =
+                    (userInfo.userCollege.collegeId == -1 || userInfo.userDepartment.departmentId == -1)
             )
-        }
+        )
     }
 
-    private fun getUserDepartment() {
-        viewModelScope.launch {
-            val (college, department) = userRepository.getUserCollegeDepartment() ?: run {
-                _uiState.value = UiState.Error
-                _uiEvent.emit(
-                    UiEvent.ShowToast(
-                        UiText.StringResource(R.string.not_found),
-                        ToastType.ERROR
-                    )
+    private suspend fun getUserDepartment() {
+        val (college, department) = userRepository.getUserCollegeDepartment() ?: run {
+            _uiEvent.emit(
+                UiEvent.ShowToast(
+                    UiText.StringResource(R.string.not_found),
+                    ToastType.ERROR
                 )
-                return@launch
-            }
+            )
+            return
+        }
 
-            setUserCollegeDepartmentUseCase(college, department)
+        setUserCollegeDepartmentUseCase(college, department)
 
-            _uiState.value = UiState.Success(
-                MainState.DepartmentState(
-                    departmentName = department.departmentName,
-                    showUserDepartmentBottomSheet =
-                        (college.collegeId == -1 || department.departmentId == -1)
-                )
+        _uiState.value = UiState.Success(
+            MainState.DepartmentState(
+                departmentName = department.departmentName,
+                showUserDepartmentBottomSheet =
+                    (college.collegeId == -1 || department.departmentId == -1)
             )
-        }
+        )
     }
+
 }
 
 
 sealed class MainState {
     object NicknameNull : MainState()
-    data class NicknameExists(val nickname: String) : MainState()
     object LoggedOut : MainState()
     data class DepartmentState(
         val departmentName: String? = "",

app/src/main/java/com/eatssu/android/presentation/cafeteria/CafeteriaFragment.kt

@@ -13,7 +13,6 @@ import com.eatssu.android.databinding.FragmentCafeteriaBinding
 import com.eatssu.android.presentation.MainViewModel
 import com.eatssu.android.presentation.base.BaseFragment
 import com.eatssu.android.presentation.cafeteria.calendar.CalendarAdapter
-import com.eatssu.android.presentation.cafeteria.calendar.CalendarAdapter.OnItemListener
 import com.eatssu.android.presentation.util.CalendarUtil
 import com.eatssu.android.presentation.util.CalendarUtil.daysInWeekArray
 import com.eatssu.android.presentation.util.CalendarUtil.monthYearFromDate
@@ -28,7 +27,7 @@ import java.time.LocalDate
 @AndroidEntryPoint
 class CafeteriaFragment : BaseFragment<FragmentCafeteriaBinding>(
     ScreenId.HOME_MAIN
-), OnItemListener {
+), CalendarAdapter.OnItemListener {
 
     private val mainViewModel by activityViewModels<MainViewModel>()
 
@@ -86,9 +85,9 @@ class CafeteriaFragment : BaseFragment<FragmentCafeteriaBinding>(
     }
 
     private fun setWeekView() {
-        monthYearText?.text = CalendarUtil.selectedDate?.let { monthYearFromDate(it) }
-        val days = CalendarUtil.selectedDate?.let { daysInWeekArray(it) }
-        val calendarAdapter = days?.let { CalendarAdapter(it, this) }
+        monthYearText?.text = monthYearFromDate(CalendarUtil.selectedDate)
+        val days = daysInWeekArray(CalendarUtil.selectedDate)
+        val calendarAdapter = CalendarAdapter(days, this)
         val gridLayoutManager = GridLayoutManager(requireContext(), 7)
 
         calendarRecyclerView?.layoutManager = gridLayoutManager

app/src/main/java/com/eatssu/android/presentation/cafeteria/review/modify/ModifyViewModel.kt

@@ -74,6 +74,7 @@ class ModifyViewModel @Inject constructor(
                         ToastType.ERROR
                     )
                 )
+                return@launch
             }
 
             _uiEvent.emit(UiEvent.NavigateBack)

app/src/main/java/com/eatssu/android/presentation/cafeteria/review/write/WriteReviewViewModel.kt

@@ -115,6 +115,12 @@ class WriteReviewViewModel @Inject constructor(
                         val compressedFile = compressImage(context, originalFile)
                         if (compressedFile != null && compressedFile.exists()) {
                             imageUrl = getImageUrlUseCase(compressedFile)
+                            if (imageUrl == null) {
+                                _uiState.value = UiState.Success(editing) // 되돌림
+                                _uiEvent.emit(UiEvent.ShowToast(UiText.StringResource(R.string.toast_image_upload_failed), ToastType.ERROR))
+                                originalFile.delete()
+                                return@launch
+                            }
                             _uiEvent.emit(UiEvent.ShowToast(UiText.StringResource(R.string.toast_image_upload_success), ToastType.SUCCESS))
 
                             // 원본 파일 삭제 (압축된 파일만 유지)

app/src/main/java/com/eatssu/android/presentation/mypage/myreview/MyReviewListScreen.kt

@@ -180,8 +180,6 @@ internal fun MyReviewListScreen(
                                     )
                                 }
                             }
-
-                            null -> TODO()
                         }
                     }
 
@@ -325,4 +323,4 @@ fun ReviewListEmptyPreview() {
             )
         )
     }
-}
+}

app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoViewModel.kt

@@ -209,10 +209,30 @@ class UserInfoViewModel @Inject constructor(
     fun saveUserInfo() {
         viewModelScope.launch {
             val currentState = _uiState.value as? UiState.Success ?: return@launch
+            val data = currentState.data
+
+            if ((data.isCollegeChanged || data.isDepartmentChanged) && data.selectedDepartment == null) {
+                _uiEvent.emit(
+                    UiEvent.ShowToast(
+                        UiText.StringResource(R.string.toast_department_required),
+                        ToastType.ERROR
+                    )
+                )
+                return@launch
+            }
+
+            if ((data.isCollegeChanged || data.isDepartmentChanged) && data.selectedCollege == null) {
+                _uiEvent.emit(
+                    UiEvent.ShowToast(
+                        UiText.StringResource(R.string.toast_college_required),
+                        ToastType.ERROR
+                    )
+                )
+                return@launch
+            }
 
             _uiState.update { UiState.Loading }
 
-            val data = currentState.data
             var nicknameUpdated = false
             var departmentUpdated = false
 
@@ -234,8 +254,29 @@ class UserInfoViewModel @Inject constructor(
 
             // 학과/단과대 변경이 있는 경우
             if (data.isCollegeChanged || data.isDepartmentChanged) {
-                val department = data.selectedDepartment ?: return@launch
-                val college = data.selectedCollege ?: return@launch
+                val department = data.selectedDepartment
+                if (department == null) {
+                    _uiState.value = UiState.Success(data)
+                    _uiEvent.emit(
+                        UiEvent.ShowToast(
+                            UiText.StringResource(R.string.toast_department_required),
+                            ToastType.ERROR
+                        )
+                    )
+                    return@launch
+                }
+
+                val college = data.selectedCollege
+                if (college == null) {
+                    _uiState.value = UiState.Success(data)
+                    _uiEvent.emit(
+                        UiEvent.ShowToast(
+                            UiText.StringResource(R.string.toast_college_required),
+                            ToastType.ERROR
+                        )
+                    )
+                    return@launch
+                }
 
                 val success = userRepository.setUserDepartment(department.departmentId)
                 if (!success) {