-
Notifications
You must be signed in to change notification settings - Fork 73
Clone specific software-layer-commit and implement CI to check merged status #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clone specific software-layer-commit and implement CI to check merged status #1353
Conversation
|
Let's do a small test build to see if the new |
|
TODO: I guess in this same PR we should still add a check that verifies that the SHA-checksum of |
…casparvl/software-layer into improve_software_layer_scripts_workflow
|
Perfect. As expected, after changing the
Changing the
|
|
Ok, as expected, both Let's test again by changing the sha checksum... |
|
Ok, on bee1d29 we again have the expected failure:
Let's change the sha checksum back, and now change something in |
…f this causes the associated CI job to fail
|
Again, we get the expected failure:
|
This PR is an initial step in creating a workflow where we can use PRs to
software-layer-scriptsdirectly, and then once they are merged, just update the SHA checksum to a (Github-signed) merge commit, rebuild, and be done :)Edit: better description...
This PR contains three changes:
bot/build.shnow clones a particular commit, which is specified inbot/commit_shaVerify software-layer-scripts / check_bot_build_checksumverifies the checksum ofbot/build.shagainst a reference hardcoded in the workflow file. This way, a malicious contributor would have to modify bothbot/build.shand the workflow file, which would (hopefully) stand out to a reviewer.Verify software-layer-scripts / check_software_layer_scripts_commitwhich check thatbot/commit_shais a commit that is part of the upstream https://github.com/EESSI/software-layer-scripts , is on themainbranch (i.e. has been merged), is a merge commit, and is signed with the public Github GPG for the web interface.We might need to update the
commit_shaalready (not sure if there have been more merges to software-layer-scripts since I started this) before we merge this to make sure this PR doesn't actually revert us to using an older version.