Draft
Conversation
Collaborator
|
Because of the number of fields here, and because this won't be the default way of running, we will need a switch to activate passing these fields through the system. This should be a namelist item added to the drv_flds_in namelist file. That's the first thing I see from a first pass of looking through this. |
|
Let's assess the scientific priority of the CTSM side of this PR before pushing forward on the externals associated with the work. |
Collaborator
|
Please refer to the related CTSM PR for further discussion and timeline. I am converting this to draft status for now. |
Member
|
Wanted to note here that I'm the assignee for the parent PR, ESCOMP/CTSM#1975. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Here we add support for sectoral water abstraction module in CESM.
While the withdrawal, consumption and return flow fluxes for each of the sectors are computed in the land component (CLM/CTSM), the water is supplied from the routing model (MOSART in our case).
Therefore, there is a need to communicate these fluxes between the two models.
CMEPS Issues Fixed (include github issue #): 350
Are changes expected to change answers?
In the land component, there will be some small changes to the surface water-energy balance due to the fact that we apply the consumed water for sectoral usage on top of the soil columns covered by natural vegetation.
In the routing model, there will be some changes to the total water storage (VOLR) and final discharge into the oceans, since the sectoral water usage have a consumption element (meaning that the withdrawal is larger than the return flow, as some water is lost in the process).
Any User Interface Changes (namelist or namelist defaults changes)?
Not in CMEPS specifically, but yes.
In CTSM, we added some new namelist variables with default values already fixed. More about this in the dedicated pull request for the CTSM codebase.
Testing performed
Extensive testing was performed, with different namelist configurations. Main goal was testing the model performance, then there are no inconsistencies between expected model behavior and results, but also model stability.
The model is behaving according to the design, and is completely stable (we performed simulations up to 30 years with no errors or issues).
For any questions, please contact me at sabin.taranu@vub.be.
I will be happy to assist to resolve any issues or anything unclear.