refactor(schemacache): move useSchemaCache from hooks to stores (closes #447) - #475
Open
EVWorth wants to merge 1 commit into
Open
refactor(schemacache): move useSchemaCache from hooks to stores (closes #447)#475EVWorth wants to merge 1 commit into
EVWorth wants to merge 1 commit into
Conversation
#447) The Zustand store for the schema cache lived in src/hooks/ — a convention smell that hid it from `grep src/stores` and confused new contributors expecting the project's store layout (editorStore, connectionStore, etc. all live under src/stores/). Moves: - src/hooks/useSchemaCache.ts → src/stores/schemaCacheStore.ts - src/hooks/__tests__/useSchemaCache.test.ts → src/stores/__tests__/schemaCacheStore.test.ts - Renames export useSchemaCache → useSchemaCacheStore (Zustand store convention) Updates all 8 consumers (3 prod, 5 test mocks) to import the new path and name. Verified: - vitest 1538/1538 pass (no behavior change) - tsc --noEmit clean - eslint clean (pre-existing warnings only) Closes #447 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Zustand store for the schema cache lived in
src/hooks/— a convention smell that hid it fromgrep src/storesand made new contributors miss it (the other 8 stores all live undersrc/stores/).Mechanical rename:
src/hooks/useSchemaCache.ts→src/stores/schemaCacheStore.tssrc/hooks/__tests__/useSchemaCache.test.ts→src/stores/__tests__/schemaCacheStore.test.tsuseSchemaCache→useSchemaCacheStore(Zustand store convention)All 8 consumers (3 prod, 5 test mocks) updated to the new path and name.
Files
Test plan
Closes #447