Skip to content

Fix Life Pulse rhythm workspace scoping#116

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/critical-bug-investigation-afa0
Draft

Fix Life Pulse rhythm workspace scoping#116
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/critical-bug-investigation-afa0

Conversation

@cursor

@cursor cursor Bot commented Jul 12, 2026

Copy link
Copy Markdown

Summary

  • Fix a critical workspace split in desktop Life Pulse rhythm: due checks used the active workspace, but skilllite schedule tick ran without --workspace.
  • Pass the active workspace through the existing schedule tick --workspace <path> CLI contract.
  • Add a focused regression test that preserves workspace paths containing spaces as a single argument.

Task Linkage

  • Task ID: TASK-2026-070
  • Task folder: tasks/TASK-2026-070-life-pulse-rhythm-workspace/

Injected Specs

  • spec/architecture-boundaries.md (assistant/CLI boundary reviewed; no dependency changes)
  • spec/security-nonnegotiables.md (not sandbox/security policy)
  • spec/testing-policy.md (Rust code change)
  • spec/docs-sync.md (reviewed; no docs needed because this uses an existing documented flag)

Validation Evidence

  • Commands executed:
    • cargo fmt --check
    • python3 scripts/validate_tasks.py
    • cargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml life_pulse::tests::rhythm_args_include_active_workspace
    • cargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml
    • cargo test
    • cargo clippy --all-targets -- -D warnings
  • Key results:
    • Format check passed.
    • Task validation passed: 70 task directories checked.
    • Focused Life Pulse test passed: 1 passed; 0 failed.
    • Assistant Tauri crate tests passed: 54 passed; 0 failed.
    • Root cargo test passed.
    • Root Clippy is blocked by a pre-existing unrelated lint: crates/skilllite-core/src/config/schema.rs:313 clippy::manual_filter.

Regression Scope

  • Areas likely affected:
    • Desktop Life Pulse rhythm subprocess startup.
    • Scheduled agent runs launched from desktop heartbeat.
  • Explicit non-goals:
    • CLI schedule behavior outside Life Pulse.
    • Evolution growth subprocess behavior.
    • Schedule file/state semantics.

Docs Sync (EN/ZH)

  • Not needed
  • Updated EN + ZH docs
  • Files:
    • N/A

Review Checklist

  • Acceptance criteria in tasks/.../TASK.md satisfied (or explicitly deferred)
  • tasks/.../STATUS.md updated with latest progress
  • tasks/.../REVIEW.md includes merge readiness decision
  • tasks/board.md status is up to date
Open in Web View Automation 

cursoragent and others added 2 commits July 12, 2026 11:05
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant