Skip to content

Release shard locks one at a time - #10686

Open
tylergibbs1 wants to merge 2 commits into
Effect-TS:mainfrom
tylergibbs1:fix-cluster-shard-release-burst
Open

tylergibbs1 wants to merge 2 commits into
Effect-TS:mainfrom
tylergibbs1:fix-cluster-shard-release-burst

Conversation

@tylergibbs1

@tylergibbs1 tylergibbs1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Prevent concurrent shard releases from queueing enough statements on a reserved SQL lock connection to trigger its operation deadline and drop retained locks.

Maintainer takeover

Moved serialization from Sharding to SqlRunnerStorage. Only releases using a reserved connection (PostgreSQL and MySQL, including row-lock mode) take a one-permit semaphore, outside the operation deadline. Pooled dialects and custom storages retain concurrent releases. Bulk release is unchanged; deadline-based connection recovery remains intact.

Removed the simulated Sharding session test, timing-based handoff test, slow-fault harness extension, and README change. Replaced them with one focused PostgreSQL regression in the existing SqlRunnerStorage integration suite: hold the reserved connection, start three releases, verify only one reaches the connection, resume them, and verify the session and retained lock survive.

The possible per-shard reply-refresh burst is out of scope.

Validation

  • Regression fails before the storage fix: three active statements instead of one; passes afterward.
  • Full SqlRunnerStorage.integration.test.ts: 57 tests passed, including PostgreSQL, MySQL, Vitess, SQLite, row-lock variants, and deadline-rebuild coverage.
  • pnpm lint-fix and pnpm check passed (run through nix develop -c).

Related to #10673; #10677 addresses the separate database disk-flush trigger.

Closes EFF-3864

When a runner joins, the runner handing shards off releases them all at
once. On PostgreSQL and MySQL every lock operation runs on one reserved
connection, so the releases queue together. A burst longer than the lock
operation deadline times every release out, SqlRunnerStorage replaces the
lock connection, and closing the old session drops every lock the runner
holds, including the shards it keeps. Requests on those shards can then
run twice.

Release one lock at a time, so a refresh or acquire waits behind at most
one release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 05120d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-cloudflare Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-janitor effect-janitor Bot added the 4.0 label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 40.09 KB 40.09 KB 0.00 KB (0.00%)
basic.ts 7.31 KB 7.31 KB 0.00 KB (0.00%)
batching.ts 11.21 KB 11.21 KB 0.00 KB (0.00%)
brand.ts 7.00 KB 7.00 KB 0.00 KB (0.00%)
cache.ts 11.73 KB 11.73 KB 0.00 KB (0.00%)
config.ts 23.09 KB 23.09 KB 0.00 KB (0.00%)
differ.ts 22.20 KB 22.20 KB 0.00 KB (0.00%)
http-client.ts 27.45 KB 27.45 KB 0.00 KB (0.00%)
http-router.ts 37.59 KB 37.59 KB 0.00 KB (0.00%)
logger.ts 12.19 KB 12.19 KB 0.00 KB (0.00%)
metric.ts 9.65 KB 9.65 KB 0.00 KB (0.00%)
optic.ts 7.21 KB 7.21 KB 0.00 KB (0.00%)
pubsub.ts 16.21 KB 16.21 KB 0.00 KB (0.00%)
queue.ts 13.09 KB 13.09 KB 0.00 KB (0.00%)
schedule.ts 11.99 KB 11.99 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 14.29 KB 14.29 KB 0.00 KB (0.00%)
schema-binary.ts 42.48 KB 42.48 KB 0.00 KB (0.00%)
schema-class.ts 21.96 KB 21.96 KB 0.00 KB (0.00%)
schema-codegen.ts 30.70 KB 30.70 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 30.56 KB 30.56 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 28.26 KB 28.26 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.54 KB 15.54 KB 0.00 KB (0.00%)
schema-string.ts 12.50 KB 12.50 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.43 KB 16.43 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 39.63 KB 39.63 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 21.11 KB 21.11 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 21.28 KB 21.28 KB 0.00 KB (0.00%)
schema-toFormatter.ts 21.37 KB 21.37 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 26.42 KB 26.42 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 21.45 KB 21.45 KB 0.00 KB (0.00%)
schema.ts 21.05 KB 21.05 KB 0.00 KB (0.00%)
stm.ts 14.46 KB 14.46 KB 0.00 KB (0.00%)
stream.ts 10.56 KB 10.56 KB 0.00 KB (0.00%)

This branch is waiting to be deployed

1 waiting deployment
fork — 05120d9b Waiting Nov 17, 2026 by effect-bot via approval-gate #26464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants