Skip to content

Fix pre-limbo profile request plugins (e.g. Floodgate) being lost after /velocity reload #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhanu20-00 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pre-limbo profile request plugins (e.g. Floodgate) being lost after /velocity reload #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions plugin/src/main/java/net/elytrium/limboapi/LimboAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,17 @@ public void reload() {
eventManager.register(this, new DisconnectListener(this));
eventManager.register(this, new ReloadListener(this));

// Without this, the pre-limbo profile request plugins (e.g. Floodgate) hoisted at boot by
// postProxyInitialization() are lost on every /velocity reload: unregisterListeners() above drops the
// old EventManagerHook (and with it, the reference to their handler), and the new EventManagerHook
// created above starts with empty handler state, so those plugins' GameProfileRequestEvent handlers
// never get re-hoisted and simply stop firing until the proxy is fully restarted.
try {
this.eventManagerHook.reloadHandlers();
} catch (IllegalAccessException e) {
LOGGER.error("Failed to reload pre-limbo profile request plugin handlers", e);
}

LOGGER.info("Loaded!");
}

Expand Down