Add lighting scene IDs to lighting system#295
Closed
ryanhcode wants to merge 2 commits intoEngine-Room:1.21.1/devfrom
Closed
Add lighting scene IDs to lighting system#295ryanhcode wants to merge 2 commits intoEngine-Room:1.21.1/devfrom
ryanhcode wants to merge 2 commits intoEngine-Room:1.21.1/devfrom
Conversation
Jozufozu
requested changes
Aug 30, 2025
Member
Jozufozu
left a comment
Jozufozu
left a comment
There was a problem hiding this comment.
This all looks pretty clean to me, but we should have the Backend API to provide data for lighting scenes before this merges, though I'm open to being convinced otherwise
| bool _flw_chunkCoordToSectionIndex(ivec3 sectionPos, out uint index) { | ||
| bool _flw_chunkCoordToSectionIndex(uint sceneId, ivec3 sectionPos, out uint index) { | ||
| uint scene; | ||
| if (_flw_nextLut(0u, int(sceneId), scene) || scene == 0u) { |
Member
There was a problem hiding this comment.
The cast to int here is a little spooky since the data really is a uint, but we'll realistically run out of memory before this causes issues.
Still, it could be good to have a copy of _flw_nextLut that takes a uint index
Member
There was a problem hiding this comment.
We probably need to expose the scene ID/embedding ID here
Author
|
Yeah, before the merge getting the API for interacting with scenes in would be a good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR for adding support for a top-level "lighting scene ID" layer to the lighting LUT and API's regarding it, with the goal of allowing for sub-levels and similar use-cases to operate with Flywheel lighting.