Skip to content

Validation for EnsEMBL/Web/Mailer#1145

Merged
EbiArnie merged 4 commits intopostreleasefix/115from
fix/mailer
Feb 26, 2026
Merged

Validation for EnsEMBL/Web/Mailer#1145
EbiArnie merged 4 commits intopostreleasefix/115from
fix/mailer

Conversation

@EbiArnie
Copy link
Copy Markdown
Contributor

Make the Mailer validate input data

Make the Mailer validate input data
@sgiorgetti sgiorgetti changed the base branch from release/115 to postreleasefix/115 February 19, 2026 16:13
@sgiorgetti sgiorgetti added the bug label Feb 19, 2026
Copy link
Copy Markdown
Contributor

@sgiorgetti sgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@TamaraNaboulsi TamaraNaboulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding proper validations to mail parameters + splitting mails with and without attachments for simplification. Looks good to me.

@EbiArnie EbiArnie marked this pull request as draft February 23, 2026 10:21
@EbiArnie EbiArnie marked this pull request as ready for review February 23, 2026 12:29
Remove double semicolons
Copy link
Copy Markdown
Contributor

@sgiorgetti sgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EbiArnie EbiArnie merged commit 94652f1 into postreleasefix/115 Feb 26, 2026
@EbiArnie EbiArnie deleted the fix/mailer branch February 26, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants