Skip to content

Add Buildifier#187

Merged
furtib merged 13 commits intoEricsson:mainfrom
furtib:add-buildifier
Apr 3, 2026
Merged

Add Buildifier#187
furtib merged 13 commits intoEricsson:mainfrom
furtib:add-buildifier

Conversation

@furtib
Copy link
Copy Markdown
Contributor

@furtib furtib commented Feb 3, 2026

Why:
We want to lint not just our Python but also our .bzl files.

What:

  • Add buildifier_prebuilt as a bazel dependency
  • Create test rule for buildifier_prebuilt
  • ordered dictionaries
  • fixed load statementes missing
    Addresses:
    Buildifier #155

@furtib furtib requested a review from Szelethus February 3, 2026 18:54
@furtib furtib self-assigned this Feb 3, 2026
@furtib furtib added the CI 📦 label Feb 3, 2026
@furtib
Copy link
Copy Markdown
Contributor Author

furtib commented Feb 3, 2026

Sorry, I messed up the previous PR.
We were in a state where the output was illegible, and I tried a couple of things to improve readability.

I tried my best to find a more legible output format.
The best so far is instead of checking the logs, looking at the summary tab under the action. (I somehow even got syntax highlighting to work there, at the cost of having to run buildifier a third time, the first 2 are unavoidable)

@furtib
Copy link
Copy Markdown
Contributor Author

furtib commented Feb 5, 2026

I'm rebasing the formatting PR to this.
To see the formatter warnings, see:
https://github.com/Ericsson/codechecker_bazel/actions/runs/21643464278/job/62389195527?pr=187

@furtib furtib force-pushed the add-buildifier branch 4 times, most recently from 3ab3a58 to ebf8763 Compare March 12, 2026 17:07
@furtib
Copy link
Copy Markdown
Contributor Author

furtib commented Mar 12, 2026

If it were to pass, this would be the most solid option.
I will look for a way to do the same with pylint and so on.
If that is possible, we might not even need a separate job, since linting will be run with bazel test ....

Copy link
Copy Markdown
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@furtib furtib merged commit 3c61927 into Ericsson:main Apr 3, 2026
15 checks passed
furtib added a commit that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants