feat: disable links no longer relevant post-conference - #1836
Conversation
Disable ticket, remote, and visa page links site-wide, by removing them from the menus and placing a TODO to re-enable next year. The pages themselves still exist. The remote ticket banner at the top of the site was also hidden.
There was a problem hiding this comment.
Pull request overview
Disables post-conference navigation/CTAs by removing ticket/remote/visa entry points from global navigation and hiding the remote banner, while leaving the underlying pages in place.
Changes:
- Commented out the top “remote” banner and adjusted header positioning to match.
- Removed ticket/remote/visa links from navigation data and footer quick links.
- Hid “Register Now” CTAs in the hero section and header.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/layouts/Layout.astro | Disables the remote banner via HTML comments. |
| src/data/nav.ts | Comments out ticket/remote/visa links and removes the “Attend” menu + footer quick links entries. |
| src/components/sections/hero/hero.astro | Hides the “Register Now” CTA in the hero area. |
| src/components/Header.astro | Hides mobile/desktop CTAs (and Discord icon) and updates fixed-nav top offset. |
Comments suppressed due to low confidence (1)
src/components/Header.astro:150
- The header’s Discord icon/link is also being disabled here, but this isn’t mentioned in the PR description (which focuses on ticket/remote/visa links and the remote banner). Either document this additional removal in the PR description or keep Discord enabled if it should remain available year-round.
<!--
TODO: Re-enable next year!
<a
href="/discord"
class="nav-icon-btn"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
src/data/nav.ts:187
- This change comments out the entire "Attend" top-level menu, which also removes access to pages like Financial Aid, Volunteering, FAQ, Accessibility, etc. The PR description only calls out disabling ticket/remote/visa links, so it looks like more navigation than intended is being removed. Consider keeping the Attend menu and only removing the ticket/remote/visa items (and update the menu URL away from /tickets).
// TODO: Re-enable next year!
// Attend
// {
// label: "Attend",
// url: "/tickets",
src/components/Header.astro:122
- The PR description mentions disabling ticket/remote/visa links, but this block also hides the mobile "Jobs" CTA. If Jobs should remain visible, consider only disabling the tickets CTA here (or update the PR description/scope accordingly).
<!--
TODO: Re-enable next year!
<li class="nav-item nav-mobile-cta">
<a class="nav-link-btn" href="/jobs">Jobs</a>
</li>
<li class="nav-item nav-mobile-cta">
<a class="nav-link-btn" href="/tickets">Register Now</a>
</li>
-->
src/components/Header.astro:173
- This block hides the desktop "Jobs" CTA alongside the "Register Now" ticket CTA. If the intent is only to disable ticket/remote/visa links, consider re-enabling Jobs here and only keeping the tickets CTA disabled (or update the PR description/scope accordingly).
<!--
TODO: Re-enable next year!
<a href="/jobs" class="nav-cta-desktop">Jobs</a>
<a href="/tickets" class="nav-cta">Register Now</a>
-->
|
We don't need to remove links, some pages will be disabled and links will disappear by default, |
This pull request primarily disables ticketing- and attendance-related navigation and call-to-action elements throughout the site, in preparation for the event's conclusion or for maintenance until next year. The changes are wrapped in comments with TODO notes for easy re-enabling in the future. It also updates navigation positioning and clarifies the handling of the old event banner.
Navigation and CTA removals:
src/components/Header.astro,src/components/sections/hero/hero.astro,src/data/nav.ts) [1] [2] [3] [4] [5] [6] [7].Navigation layout adjustment:
navCSStopproperty from40pxto0to accommodate the (now disabled) event banner, with a comment explaining when to revert this change (src/components/Header.astro).Event banner handling:
src/layouts/Layout.astro).These changes ensure that users no longer see outdated CTAs or navigation items, and make it straightforward to restore them for future events.