Skip to content

[CFI] Show Merchant, Date, Amount Fields in the Scan flow - #100426

Draft
thelullabyy wants to merge 2 commits into
Expensify:mainfrom
thelullabyy:feat-93854
Draft

[CFI] Show Merchant, Date, Amount Fields in the Scan flow#100426
thelullabyy wants to merge 2 commits into
Expensify:mainfrom
thelullabyy:feat-93854

Conversation

@thelullabyy

@thelullabyy thelullabyy commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #93854
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONFIG.ts 85.29% <100.00%> (+0.44%) ⬆️
src/CONST/index.ts 91.22% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/components/CenteredModalLayout/index.tsx 100.00% <100.00%> (ø)
src/components/ConnectToCertiniaFlow/index.tsx 2.70% <ø> (ø)
src/components/ConnectToNetSuiteFlow/index.tsx 0.00% <ø> (ø)
...ksOnlineFlow/BaseConnectToQuickbooksOnlineFlow.tsx 97.43% <ø> (ø)
...omponents/EmojiSuggestions/EmojiSuggestionItem.tsx 100.00% <100.00%> (ø)
...c/components/EnvironmentContextProvider/default.ts 100.00% <100.00%> (ø)
... and 191 more
... and 33 files with indirect coverage changes

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚧 trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100426.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ❌ FAILED ❌
The build for Android was skipped The QR code can't be generated, because the iOS build failed
Web 🕸️
https://100426.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@trjExpensify

trjExpensify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Took the adhoc draft for a quick spin.

  • I think we need the Automatic text inside the Amount, Merchant and Date fields like the OP of the parent issue.
image image

Reason being, a user might click "Show more" to reveal more fields on the expense but intends to leave merchant, date, amount blank still - and we would proceed with scanning them automatically if they do leave them blank.

I could see us removing the labels on all three when a value is entered in any of them though, as that's really the point in which we won't automatically read them anymore. Curious to hear what Shawn thinks about that.

  • I don't think we should auto-focus the amount field when they click "Show more" as I think it encourages manual entry, whereas "Show more" needs to be used to access other fields on the expense. The intention of what they want to fill out isn't really clear in this case.
2026-09-08_14-25-02.mp4
  • The error handling seems off in this case:
  1. Click "Show more"
  2. Enter a merchant name
  3. Click "Create expense"
  4. Blocked from creating the expense, in-line errors appear for the Amount and Date fields
  5. Clear the Merchant field
  6. Click "Create expense" again
  7. Still blocked from creating the expense.

Why is that? I've cleared the three mandatory fields if this was to be created manually instead of scanned, so I should be able to proceed with creating the expense right?

2026-09-08_15-04-07.mp4

CC: @shawnborton for thoughts.

@shawnborton

Copy link
Copy Markdown
Contributor

I could see us removing the labels on all three when a value is entered in any of them though, as that's really the point in which we won't automatically read them anymore

Oh interesting, I didn't realize that. I think that makes sense, otherwise it's odd to say Automatic in a case where we actually don't scan the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants