Add Campfire integration - #100446
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@Expensify/design Please attach the Campfire icon |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9d82e2172
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| key={key} | ||
| /> | ||
| ), | ||
| onImportPagePress: () => null, |
There was a problem hiding this comment.
Wire Campfire configuration rows to working pages
For every verified Campfire connection, PolicyAccountingPage creates the Import, Export, and Advanced configuration rows from this integration data, but all three handlers (onImportPagePress, onExportPagePress, and onAdvancedPagePress) return without navigating. Consequently, administrators can connect Campfire but tapping any of its primary configuration controls does nothing, making the advertised coding, export, and synchronization settings inaccessible; these rows should either route to implemented pages or remain hidden until those pages exist.
Useful? React with 👍 / 👎.
| import CertiniaSquare from '@assets/images/integrationicons/certinia-icon-square.svg'; | ||
| import CircleSlash from '@assets/images/integrationicons/circle-slash.svg'; | ||
| import DualEntrySquare from '@assets/images/integrationicons/dualentry-icon-square.svg'; | ||
| import CampfireSquare from '@assets/images/integrationicons/dualentry-icon-square.svg'; |
There was a problem hiding this comment.
Use the Campfire logo for CampfireSquare
This aliases CampfireSquare to the DualEntry SVG, so every newly added Campfire surface—including the accounting option, upgrade screen, and export indicators—displays the DualEntry logo. Import an actual Campfire asset rather than reusing the unrelated integration's branding.
Useful? React with 👍 / 👎.
|
Icon is here: campfire.svg.zip Feel free to rename it to match the other icons we have in the repo. |
Explanation of Change
Fixed Issues
$ #100177
$ #100178
$ #100179
PROPOSAL:
Tests
Offline tests
n/a
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari