Vendor matching CC - R1: App Phase 2 (Default vendor row)

[Beamanator]

Explanation of Change

Phase 2 of Vendor matching CC - R1: App — adds the workspace-admin "Default vendor" row in QBO Company Card export settings for Credit/Debit-card export destinations. Mirrors the existing Vendor Bill default-vendor flow.

The new row appears in DynamicQuickbooksCompanyCardExpenseAccountPage whenever hasVendorFeature(policy, isBetaEnabled(BETAS.VENDOR_MATCHING)) is true — i.e., the workspace has the vendorMatching beta enabled AND QBO is connected with nonReimbursableExpensesExportDestination set to CREDIT_CARD or DEBIT_CARD. Tapping the row navigates to a new QuickbooksNonReimbursableCreditCardDefaultVendorSelectPage (RHP), which lets the admin pick a vendor from connections.qbo.data.vendors; selection calls the updateQuickbooksOnlineNonReimbursableCreditCardDefaultVendor action shipped in Phase 1.

Why this looks small

Three pieces of the original Phase 2 plan have been intentionally deferred:

1. Policy.areVendorsEnabled + MORE_FEATURES.ARE_VENDORS_ENABLED + locked More Features card — verified that neither Auth nor Web-Expensify has a server-side areVendorsEnabled policy NVP today (only the transaction-level vendor NVP from the Auth foundation PR) and the PHP fuzzy matcher in the Web-Expensify commands and event hooks PR gates on BETA_VENDOR_MATCHING + QBO config alone, not on any per-workspace toggle. Adding the App-side toggle would be pure UI state with no server-side enforcement — would need a coordinated Auth + Web-E change first. Until that lands, the right gate is hasVendorFeature(policy, beta) (existing from Phase 1), which is what this PR consumes. The Vendors More Features card itself can be added in a future PR alongside the server-toggle work if/when the design calls for it.
2. Vendors tab in workspace navigation — read-only display of the imported QBO vendor list. Substantial nav/route/linking-config boilerplate; better landed alongside the Phase 3 expense-flow work where there's a clear user need for browsing the vendor list (the vendor selector RHP).
3. Two pushTransactionViolationsOnyxData callers (export-type change + vendor-list sync) — selectExportCompanyCard uses the generic updateManyPolicyConnectionConfigs and atomically writes three fields in one API call, so threading the violation push into that flow requires either refactoring out of the generic helper or introducing a vendor-specific wrapper action. The vendor-list sync (callsite 2) has no existing hook pattern (no Onyx subscriber or server-push currently). Since zero workspaces are on the vendorMatching beta today and the client-side violation recompute happens lazily on any next transaction edit, the cost-of-delay is essentially nil. Worth handling properly in a focused Phase 2b PR rather than rushed here.

The Phase 1 PR description called Phase 2 "workspace settings". This PR delivers the Default vendor settings — the only piece that doesn't require new server coordination, an Onyx subscriber, or a nav-config diff bigger than the actual logic.

Cross-PR dependencies

• Auth foundation PR (merged + deployed) — provides the UpdateMoneyRequestVendor command + inactiveVendor violation type. Not consumed by this PR directly, but the App Phase 1 PR consumed it.
• Web-Expensify commands and event hooks PR (merged, awaiting deploy) — contains the UpdateQuickbooksOnlineNonReimbursableCreditCardDefaultVendor PHP wrapper command this PR's UI will call. Until that deploys, the row renders and lets admins pick a vendor, but the API write will return a not-found-command error on prod.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/638653

PROPOSAL: N/A (internal feature, no external proposal)

Tests

Prerequisite: a workspace with the vendorMatching beta enabled, QBO connected, and non-reimbursable export destination set to either Credit Card or Debit Card.

1. Open the workspace's Settings > Accounting. Click Connections > QuickBooks Online > Export > Company card expenses.
2. Verify the new Default vendor menu row appears below the existing "Export as" + account rows.
3. Verify the row's title shows the current default-vendor name (or is blank when none is set).
4. Tap the row. Verify it navigates to the new "Default vendor" RHP select page.
5. Pick a vendor from the list. Verify the RHP closes, the row's title updates to the picked vendor name, and the value persists across navigation.
6. Flip the export destination to Vendor Bill (back on the previous page). Verify the new CC/DC default vendor row disappears.
7. Flip the export destination back to Credit Card or Debit Card. Verify the row reappears with the previously-set value preserved.
8. With the vendorMatching beta disabled on the workspace, verify the row is hidden regardless of export destination.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests, executed with the network disabled after step 1. Verify the row renders from cached Onyx state and that selecting a vendor surfaces the standard offline pending-action indicator (the same OfflineWithFeedback wrapping the existing Vendor Bill default-vendor row).

QA Steps

Same as Tests, but requires vendorMatching beta enablement on the QA workspace. The row has no end-user-visible effect outside of QBO admin workspace settings, so QA scope is limited to verifying the row's visibility branches and that the select-and-save round-trip lands on the workspace config.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I verified that similar component doesn't exist in the codebase
• I verified that all props are defined accurately and each prop has a /** comment above it */
• I verified that each file is named correctly
• I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
• I verified that the only data being stored in component state is data necessary for rendering and nothing else
• In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
• For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
• I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
• I verified that all JSX used for rendering exists in the render method
• I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

To be added once a local build is up — the row is structurally identical across platforms (single MenuItemWithTopDescription + RHP SelectionScreen) so platform-specific captures will be uniform.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx	6.94% <0.00%> (-0.01%)	⬇️
src/ROUTES.ts	18.14% <0.00%> (-0.07%)	⬇️
...DynamicQuickbooksCompanyCardExpenseAccountPage.tsx	0.00% <0.00%> (ø)
...nReimbursableCreditCardDefaultVendorSelectPage.tsx	0.00% <0.00%> (ø)
... and 8 files with indirect coverage changes

[Beamanator]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".