[HOLD][No QA][Onyx] Bump react-native-onyx to to report usage quota log#92085
[HOLD][No QA][Onyx] Bump react-native-onyx to to report usage quota log#92085sosek108 wants to merge 4 commits into
Conversation
|
|
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2051226ab5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "react-native-nitro-modules": "0.35.0", | ||
| "react-native-nitro-sqlite": "9.6.0", | ||
| "react-native-onyx": "3.0.75", | ||
| "react-native-onyx": "3.0.83", |
There was a problem hiding this comment.
Update the lockfile with the Onyx bump
Because this dependency is managed by package-lock.json, changing only package.json leaves the lockfile still declaring react-native-onyx as 3.0.75 in both the root dependency list and node_modules/react-native-onyx. In any clean/npm-ci install path that uses the lockfile, the tree is now out of sync with the manifest, so the intended 3.0.83 Onyx changes may not be installed (or install can fail while reconciling the mismatch). Please regenerate and commit package-lock.json for this version bump.
Useful? React with 👍 / 👎.
Julesssss
left a comment
There was a problem hiding this comment.
We need to hold this on the Onyx bump queue rather than jumping a lot of versions
|
Onyx already at this version |
Explanation of Change
Bumps react-native-onyx to Expensify/react-native-onyx#795 and Expensify/react-native-onyx#794
Fixed Issues
$ #87873
PROPOSAL:
Tests
Storage Quota Checklogs. These should containusageDetailsinformationOffline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari