[No QA] [Test] Pin react-native-onyx to #824 — serialize Error.cause - #99225
Draft
roryabraham wants to merge 7 commits into
Draft
[No QA] [Test] Pin react-native-onyx to #824 — serialize Error.cause#99225roryabraham wants to merge 7 commits into
roryabraham wants to merge 7 commits into
Conversation
Companion pin for Onyx PR #824 so App CI exercises serializing Error.cause when storage degrades.
42 tasks
Onyx.clear() models sign-out. Report-holder names resolve from the live allPersonalDetails connect, so restore PERSONAL_DETAILS_LIST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Companion / verification PR for react-native-onyx PR #824. Pins
react-native-onyxto that PR's HEAD viagit+httpsso E/App CI exercises serializingError.causewhen storage degrades before the Onyx PR merges.Pin:
"react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#dbaa4fceaa9d3435098bedbd487b577d0d56b409".The stale
react-native-onyx+3.0.98+001+batch-collection-member-removalsApp patch is removed because this SHA already includes Onyx PR #820 (released in 3.0.100).Not for merge as-is: once Onyx PR #824 merges and publishes, repin to the released version.
Fixed Issues
$
PROPOSAL:
Tests
npm installandnpm run web.Offline tests
QA Steps
Same as tests. No user-facing behavior changes; this is an Onyx library bump for CI verification.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari