Skip to content

Gate NetSuite invoice-item preference selection behind a Save button (a11y On Input, PR 13) #99239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelvinBot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gate NetSuite invoice-item preference selection behind a Save button (a11y On Input, PR 13) #99239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions ...s/workspace/accounting/netsuite/export/DynamicNetSuiteInvoiceItemPreferenceSelectPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {DYNAMIC_ROUTES} from '@src/ROUTES';

import type {ValueOf} from 'type-fest';

import React, {useCallback, useEffect, useMemo, useRef} from 'react';
import React, {useCallback, useEffect, useMemo, useRef, useState} from 'react';
import {View} from 'react-native';

type MenuListItem = ListItem & {
Expand All @@ -46,40 +46,51 @@ function DynamicNetSuiteInvoiceItemPreferenceSelectPage({policy}: WithPolicyConn

const selectedValue = Object.values(CONST.NETSUITE_INVOICE_ITEM_PREFERENCE).find((value) => value === config?.invoiceItemPreference) ?? CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.CREATE;

const [draftPreference, setDraftPreference] = useState<ValueOf<typeof CONST.NETSUITE_INVOICE_ITEM_PREFERENCE>>();
const currentPreference = draftPreference ?? selectedValue;

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear the draft when a failed save rolls back

When the preference update fails after optimistically saving SELECT, updateNetSuiteOnyxData restores config.invoiceItemPreference to the old value, but draftPreference remains SELECT and always wins here. The checkmark and focus therefore continue to show SELECT while the title and invoice-item submenu follow the rolled-back CREATE value, leaving the page in a contradictory state; reconcile or clear the draft when the Onyx value rolls back. CLAUDE.mdL82-L87

Useful? React with 👍 / 👎.


const options: MenuListItem[] = useMemo(
() =>
Object.values(CONST.NETSUITE_INVOICE_ITEM_PREFERENCE).map((postingPreference) => ({
value: postingPreference,
text: translate(`workspace.netsuite.invoiceItem.values.${postingPreference}.label`),
keyForList: postingPreference,
isSelected: selectedValue === postingPreference,
isSelected: currentPreference === postingPreference,
})),
[selectedValue, translate],
[currentPreference, translate],
);

const goBack = useCallback(() => {
Navigation.goBack(backPath);
}, [backPath]);

const selectInvoicePreference = useCallback(
(row: MenuListItem) => {
if (row.value !== config?.invoiceItemPreference && policyID) {
updateNetSuiteInvoiceItemPreference(policyID, row.value, config?.invoiceItemPreference);
}
if (row.value === CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.CREATE) {
goBack();
}
},
[config?.invoiceItemPreference, policyID, goBack],
const savePreference = useCallback(() => {
if (currentPreference !== config?.invoiceItemPreference && policyID) {
updateNetSuiteInvoiceItemPreference(policyID, currentPreference, config?.invoiceItemPreference);
}
// Selecting CREATE completes the flow, so we return to the previous screen. SELECT reveals the invoice-item sub-menu, so we stay.
if (currentPreference === CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.CREATE) {
goBack();
}
}, [currentPreference, config?.invoiceItemPreference, policyID, goBack]);

const confirmButtonOptions = useMemo(
() => ({
showButton: true,
text: translate('common.save'),
onConfirm: savePreference,
isDisabled: currentPreference === selectedValue,
}),
[savePreference, translate, currentPreference, selectedValue],
);

// Update focused index when selectedValue changes (after an error reverts the selection)
// Update focused index when the current preference changes (after an error reverts the selection)
useEffect(() => {
const selectedIndex = options.findIndex((option) => option.isSelected);
if (selectedIndex !== -1 && selectionListRef.current) {
selectionListRef.current?.updateFocusedIndex(selectedIndex);
}
}, [selectedValue, options]);
}, [currentPreference, options]);

return (
<ConnectionLayout
Expand All @@ -106,13 +117,15 @@ function DynamicNetSuiteInvoiceItemPreferenceSelectPage({policy}: WithPolicyConn
ref={selectionListRef}
data={options}
onSelectRow={(selection: SelectorType) => {
selectInvoicePreference(selection as MenuListItem);
setDraftPreference((selection as MenuListItem).value);
}}
ListItem={SingleSelectListItem}
confirmButtonOptions={confirmButtonOptions}
showScrollIndicator
shouldUpdateFocusedIndex
initiallyFocusedItemKey={options.find((mode) => mode.isSelected)?.keyForList}
style={{containerStyle: [styles.pb0]}}
addBottomSafeAreaPadding
/>
</OfflineWithFeedback>
{config?.invoiceItemPreference === CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.SELECT && (
Expand Down
Loading