[No QA] [Test] Pin react-native-onyx to stringify logAlert errors - #99242
Draft
roryabraham wants to merge 2 commits into
Draft
[No QA] [Test] Pin react-native-onyx to stringify logAlert errors#99242roryabraham wants to merge 2 commits into
roryabraham wants to merge 2 commits into
Conversation
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Companion pin for Expensify/react-native-onyx#827. Not for merge as-is.
Pins
react-native-onyxto the Onyx PR HEAD so App CI can validate the logging-only stringify change:That SHA is on 3.0.106, which already includes Onyx PR #820 (released in 3.0.100). The 3.0.98
batch-collection-member-removalsbackport patch was therefore removed andpatches/react-native-onyx/details.mdnow records that there are no active patches.After the Onyx PR is merged and published to npm, this pin should be swapped to the published version and become the bump PR.
Fixed Issues
$
PROPOSAL:
Tests
npm install).node_modules/react-native-onyxresolves to git SHAd9463eb030537099c6bcecd4041fa8edcdc09c0a.patches/react-native-onyx/no longer contains the 3.0.98 batch-collection-member-removals patch.npm run web).Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari