Guard getErrorParts against non-JSON-safe thrown values

[roryabraham]

Details

getErrorParts used String(error) for non-Error throws. That produces [object Object] for plain objects, and JSON.stringify on a circular object or BigInt can throw before classifyError runs.

Serialize non-Error throws with a try/fallback so circular objects, BigInt, functions, and symbols cannot crash storage error normalization. Plain objects keep their JSON so classifiers can still match fields like message.

Split out of #802.

Related Issues

For #802

Linked E/App PR

Expensify/App#99224

Automated Tests

Added tests/unit/storage/getErrorPartsTest.ts covering Error instances, strings, null/undefined, plain objects, circular objects, and BigInt. Existing classifyErrorTest still passes.

Manual Tests

None.

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I linked the corresponding Expensify/App PR in the ### Linked E/App PR section above, and verified this change against it (E/App CI passed and manual testing completed)
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[roryabraham]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 953364834c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Preserve messages from cross-realm errors

When an Error or DOMException originates in another realm, such as an iframe, both instanceof checks are false and its name and message properties are non-enumerable, so this returns {}. The previous String(error) path retained text such as Error: QuotaExceededError; losing it now causes classifyIDBError to return UNKNOWN instead of CAPACITY (and similarly hides other recognizable messages). Read error-like name/message fields structurally or fall back to String when JSON serialization erases them.

Useful? React with 👍 / 👎.

[roryabraham]

Cross-realm instanceof is a real JS thing, but it does not apply here.

This classifier only sees throws from our own IndexedDB / SQLite providers in the same window. Those are same-realm Error / DOMException, so the existing instanceof checks still match. We do not load Onyx inside an iframe that would produce a foreign-realm error.

Even in the hypothetical miss, this is not a regression vs main: main already used String(error) only after instanceof failed. JSON.stringify of an Error is {}, so we would lose name/message either way. classifyIDBError matching CAPACITY from QuotaExceededError still goes through the instanceof path.

Not changing this.

[os-botify]

🚀 Published to npm in 3.0.106 🎉