fix: scrub Extra Chill bucket-A layer-purity violation from core#2817
Merged
Conversation
The 'external remove' CLI error baked extrachill.com/sarai into the runtime error message every install prints. A generic substrate plugin must not surface one specific site as its canonical example. Replace with a neutral example.com/agent-slug placeholder. Closes #2816
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scrubs the single bucket-A layer-purity violation enumerated in #2816. Per the platform rule, no plugin in the Data Machine suite may know Extra Chill exists — it is generic, distributable substrate.
The issue triage confirmed core is "overwhelmingly clean": exactly one executable EC literal existed.
Violation fixed
inc/Cli/Commands/ExternalCommand.php:208— runtime CLI error string forexternal removebakedextrachill.com/saraiinto the operator-facing error message every install prints.Replaced with a neutral
example.com/agent-slugplaceholder matching the format-illustration style used elsewhere. No filter seam needed — this is prose-in-code with no behavior coupling (the data-machine-business#54/#55apply_filtersprecedent applies to behavior-affecting defaults, which this is not).Out of scope (per issue)
AgentAuthorize.php:438(*.extrachill.comsame-network check) — verified NON-violation; domain resolves at runtime fromnetwork_home_url(), EC appears only in a comment. Not touched.## EXAMPLES,@paramblocks, author/contributor tags) — tracked lower-priority prose noise, left as-is.@extrachill/chatnpm dep references) — legitimate external dependency, excluded.inc/Engine/AI/(reserved by another branch).Verification
php -l inc/Cli/Commands/ExternalCommand.php— no syntax errors.vendor/bin/phpcs inc/Cli/Commands/ExternalCommand.php— exit 0, clean (no equals-alignment or other findings on the touched file).extrachill.com/saraimatches are docblocks/@param/## EXAMPLES(bucket B).Closes #2816 (bucket-B prose remains as tracked lower-priority cleanup).